Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare karate for tests with multiple backends running at the same time #1886

Merged
merged 7 commits into from
May 26, 2024
Merged

Prepare karate for tests with multiple backends running at the same time #1886

merged 7 commits into from
May 26, 2024

Conversation

4xiom5
Copy link
Contributor

@4xiom5 4xiom5 commented May 23, 2024

  • Modified the karate Server classes to allow multiple server running at the same time.
  • Updated both backends to add some missing configuration options

@4xiom5 4xiom5 added be2-scala be1-go ci/cd continuous integration / continuous delivery labels May 23, 2024
@4xiom5 4xiom5 self-assigned this May 23, 2024
@4xiom5 4xiom5 requested a review from a team as a code owner May 23, 2024 11:56
@github-actions GitHub Actions
Copy link

Pull reviewers stats

Stats of the last 30 days for popstellar:

User Total reviews Time to review Total comments
K1li4nL
🥇		 7
▀		 5d 1h 1m
▀		 23
▀▀
pierluca
🥈		 5
▀		 6d 22h 1m
▀		 8
▀
matteosz
🥉		 5
▀		 4d 40m
 20
▀
arnauds5
 4
▀		 7d 5h 54m
▀		 12
▀
onsriahi14
 4
▀		 3d 3h 14m
 10
▀
quadcopterman
 4
▀		 5d 19h 9m
▀		 1
Tyratox
 3
▀		 14d 6h 12m
▀		 26
▀▀
simone-kalbermatter
 3
▀		 1d 3h 10m
 0
1florentin
 2
 8d 13h 48m
▀		 6
t1b00
 2
 6d 6h 52m
▀		 4
osm-alt
 2
 6d 22h 53m
▀		 12
▀
ljankoschek
 2
 18m
 0
Kaz-ookid
 2
 7d 15h 16m
▀		 7
▀
4xiom5
 1
 12d 4h 52m
▀		 0
sgueissa
 1
 2d 23h 56m
 1
MariemBaccari
 1
 1d 16h 52m
 0
DanielTavaresA
 1
 2d 19h 23m
 8
▀
⚡️ Pull request stats

emonnin-epfl
emonnin-epfl reviewed May 23, 2024
View reviewed changes
be1-go/cli/cli.go Outdated Show resolved Hide resolved
onsriahi14
onsriahi14 reviewed May 23, 2024
View reviewed changes
Copy link
Contributor

@onsriahi14 onsriahi14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on my understanding, the code appeared to be good to me.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be2-Scala'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
50.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be1-Go'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe1-Web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe2-Android'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

simone-kalbermatter
simone-kalbermatter approved these changes May 25, 2024
View reviewed changes
Copy link
Contributor

@simone-kalbermatter simone-kalbermatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

DanielTavaresA
DanielTavaresA approved these changes May 25, 2024
View reviewed changes
Copy link
Collaborator

@DanielTavaresA DanielTavaresA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tests and Server can be run rithout any issues on Scala side

@4xiom5 4xiom5 added this pull request to the merge queue May 26, 2024
Merged via the queue into master with commit 956db47 May 26, 2024
18 checks passed
@4xiom5 4xiom5 deleted the work-karate-4xiom5-handle-multiple-concurrent-servers branch May 26, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onsriahi14 onsriahi14 onsriahi14 left review comments

@DanielTavaresA DanielTavaresA DanielTavaresA approved these changes

@emonnin-epfl emonnin-epfl emonnin-epfl approved these changes

@simone-kalbermatter simone-kalbermatter simone-kalbermatter approved these changes

Assignees

@4xiom5 4xiom5

Labels
be1-go be2-scala ci/cd continuous integration / continuous delivery
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@4xiom5 @simone-kalbermatter @onsriahi14 @emonnin-epfl @DanielTavaresA