Add final json schemas & fix failing go test #1846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1florentin
requested review from
arnauds5,
ljankoschek,
onsriahi14 and
quadcopterman
Pull reviewers statsStats of the last 30 days for popstellar:
|
onsriahi14
approved these changes
May 6, 2024
arnauds5
approved these changes
May 6, 2024
1florentin
changed the title
|
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the schema of the federation_init and federation_expect message to be consistent. They now both include the "challenge" as a stand-alone FederationChallenge message, rather than object.
This helps in the implementation, because we can now see the signatures of the person that actually sent the challenge