Protocol part of the federation authentication on FE2 #1838

quadcopterman · 2024-05-01T08:30:39Z

This PR will contain the messageData for the federation authentication. There are also small UI changes to the invite and join pages :

github-actions · 2024-05-01T08:30:52Z

Pull reviewers stats

Stats of the last 30 days for popstellar:

	User	Total reviews	Time to review	Total comments
	K1li4nL 🥇	6 ▀▀	4d 22h 16m ▀	25 ▀▀▀▀
	matteosz 🥈	5 ▀▀	5d 4h 55m ▀	9 ▀▀
	arnauds5 🥉	3 ▀	18h 51m	4 ▀
	onsriahi14	3 ▀	2d 14h 7m	1
	t1b00	2 ▀	7d 16h 20m ▀	4 ▀
	MariemBaccari	2 ▀	22h 56m	0
	ljankoschek	2 ▀	18m	0
	simone-kalbermatter	2 ▀	1d 14h 29m	2
	quadcopterman	2 ▀	12d 2h 43m ▀▀	1
	Tyratox	1	4d 1h 48m ▀	3 ▀
	1florentin	1	2h 20m	0
	sgueissa	1	25m	0
	DanielTavaresA	1	3d 22h 24m ▀	2
	Kaz-ookid	1	15d 41m ▀▀▀	5 ▀
^{⚡️ Pull request stats}

…rks now

…eholder directory

Kaz-ookid

Looks good, tho I did not have an exhaustive view of all the code. I mainly focused for now on stuff I can talk about, since I worked on it very recently! QR fragments (especially manual inputs) are getting reworked in this #1850.

About the QR part, I think you tests lack testing manual inputs ! Let's meet someday and talk about how I can help you adapt to the upcoming QR fragments changes 👍

fe2-android/app/src/main/java/com/github/dedis/popstellar/ui/qrcode/QrScannerFragment.kt

fe2-android/app/src/main/java/com/github/dedis/popstellar/ui/qrcode/ScanningAction.kt

…work-fe2-johan-federation

# Conflicts: # fe2-android/app/src/main/java/com/github/dedis/popstellar/ui/qrcode/QrScannerFragment.kt # fe2-android/app/src/main/java/com/github/dedis/popstellar/ui/qrcode/ScanningAction.kt

Kaz-ookid · 2024-05-16T14:13:21Z

Hey @quadcopterman, everything seems to work fine after the merge. I adapted the QR part to fit the changes on master. I have setup manual inputs that may be wrong, just for you to see how it works and adapt it to your need! I also tried to pre-shot the strings resources you will need for that.

Also, the json format I put in jsonFormatter attribute of the ScanningActions are most likely wrong, I'll let you fill those with the correct formats!

While testing it out, I saw that erroneous manual inputs (non-empty) are not handled correctly. They indeed pop a toas with qr_code_not_federation_details stringres, but it still lets you get to the next stage of Organizations linking.

Don't forget to write some tests for the QR Scanning and Manual inputs! 👍

quadcopterman · 2024-05-16T15:44:03Z

Hey @quadcopterman, everything seems to work fine after the merge. I adapted the QR part to fit the changes on master. I have setup manual inputs that may be wrong, just for you to see how it works and adapt it to your need! I also tried to pre-shot the strings resources you will need for that.

Also, the json format I put in jsonFormatter attribute of the ScanningActions are most likely wrong, I'll let you fill those with the correct formats!

While testing it out, I saw that erroneous manual inputs (non-empty) are not handled correctly. They indeed pop a toas with qr_code_not_federation_details stringres, but it still lets you get to the next stage of Organizations linking.

Don't forget to write some tests for the QR Scanning and Manual inputs! 👍

Hey @Kaz-ookid, did you check that the app runs after your changes ? Because I still have the exact same problem I had when I tried to merge the code : the app keeps stopping when you run it. Maybe it's my Android Studio that has a problem... Just let me know if it was working for you

matteosz

Good work! But there are some mistakes in the application of the MVVM pattern

...d/app/src/main/java/com/github/dedis/popstellar/model/network/method/message/data/Objects.kt

...n/java/com/github/dedis/popstellar/model/network/method/message/data/federation/Challenge.kt

...com/github/dedis/popstellar/model/network/method/message/data/federation/ChallengeRequest.kt

...com/github/dedis/popstellar/model/network/method/message/data/federation/FederationExpect.kt

.../src/main/java/com/github/dedis/popstellar/ui/lao/federation/LinkedOrganizationsViewModel.kt

...a/com/github/dedis/popstellar/model/network/method/message/data/federation/FederationInit.kt

...id/app/src/main/java/com/github/dedis/popstellar/repository/LinkedOrganizationsRepository.kt

...p/src/main/java/com/github/dedis/popstellar/ui/lao/federation/LinkedOrganizationsFragment.kt

...main/java/com/github/dedis/popstellar/ui/lao/federation/LinkedOrganizationsInviteFragment.kt

matteosz · 2024-05-23T09:00:16Z

Also, please include screenshots/video captures in the PR description when there are major UI changes like this one

...main/java/com/github/dedis/popstellar/ui/lao/federation/LinkedOrganizationsInviteFragment.kt

sonarcloud · 2024-05-29T09:21:47Z

Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarcloud · 2024-05-29T09:24:17Z

Quality Gate passed for 'PoP - Be2-Scala'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarcloud · 2024-05-29T09:25:08Z

Quality Gate passed for 'PoP - Be1-Go'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarcloud · 2024-05-29T09:28:21Z

Quality Gate passed for 'PoP - Fe1-Web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarcloud · 2024-05-29T09:30:24Z

Quality Gate passed for 'PoP - Fe2-Android'

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
68.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

matteosz

LGTM! Great job 😄

comments addressed

Some messageData added

3c007df

quadcopterman added the fe2-android label May 1, 2024

quadcopterman self-assigned this May 1, 2024

quadcopterman added 9 commits May 1, 2024 11:32

Added more messageData

e61e5ea

Created ViewModel

cfef266

Created repository and handler for challenge messages

7e77e9b

Send message correctly

dc0eb50

Added qr scanner and other elements

a767529

Debugged scanner, added mechanisms to send federation expect and init

f0df64b

QR code is now displayed correctly, corrected a few other errors

b8ecf95

Corrected the used channel

b44c5fa

Resolve merge conflicts

d01b559

Base automatically changed from work-federation-protocol to master May 13, 2024 11:48

quadcopterman and others added 3 commits May 13, 2024 23:37

Some debugging, sending/receiving Challenge and displaying QR code wo…

f1fd114

…rks now

Corrected init and expect messages, wrote some tests

18aea21

Delete fe2-android/app/src/main/java/com/github/dedis/popstellar/plac…

260f8ad

…eholder directory

Kaz-ookid previously requested changes May 15, 2024

View reviewed changes

fe2-android/app/src/main/java/com/github/dedis/popstellar/ui/qrcode/QrScannerFragment.kt Show resolved Hide resolved

fe2-android/app/src/main/java/com/github/dedis/popstellar/ui/qrcode/ScanningAction.kt Show resolved Hide resolved

quadcopterman and others added 5 commits May 15, 2024 15:26

Some more tests

c6f7b63

Merge remote-tracking branch 'origin/work-fe2-johan-federation' into …

3b1308c

…work-fe2-johan-federation

Tests for the repository

36bb77a

Merge branch 'master' into work-fe2-johan-federation

ec32968

# Conflicts: # fe2-android/app/src/main/java/com/github/dedis/popstellar/ui/qrcode/QrScannerFragment.kt # fe2-android/app/src/main/java/com/github/dedis/popstellar/ui/qrcode/ScanningAction.kt

merged master and adapted for new QR Scanning interface

bb35d98

quadcopterman added 3 commits May 22, 2024 21:24

Subscribed to the federation channel, added tests

be8e199

Debugging and tests

a82b258

Added scanning tests

874e4d2

quadcopterman marked this pull request as ready for review May 22, 2024 21:31

quadcopterman requested a review from a team as a code owner May 22, 2024 21:31

quadcopterman requested a review from Kaz-ookid May 22, 2024 21:31

Added federation exchange qr code

17f251c

matteosz requested changes May 23, 2024

View reviewed changes

quadcopterman added 2 commits May 28, 2024 11:18

Little enhancements

5c73373

This fix is not working

b21e409

matteosz reviewed May 28, 2024

View reviewed changes

...main/java/com/github/dedis/popstellar/ui/lao/federation/LinkedOrganizationsInviteFragment.kt Outdated Show resolved Hide resolved

...main/java/com/github/dedis/popstellar/ui/lao/federation/LinkedOrganizationsInviteFragment.kt Outdated Show resolved Hide resolved

quadcopterman added 2 commits May 29, 2024 10:39

Reverted last commit and some last little improvements

bc4e9df

Added more tests for federation home and invite fragments

9ae488c

quadcopterman requested a review from matteosz May 29, 2024 09:39

matteosz approved these changes May 29, 2024

View reviewed changes

matteosz added this pull request to the merge queue May 29, 2024

Merged via the queue into master with commit eea305d May 29, 2024
18 checks passed

matteosz deleted the work-fe2-johan-federation branch May 29, 2024 13:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Protocol part of the federation authentication on FE2 #1838

Protocol part of the federation authentication on FE2 #1838

quadcopterman commented May 1, 2024 •

edited

Loading

github-actions bot commented May 1, 2024

Kaz-ookid left a comment

Kaz-ookid commented May 16, 2024 •

edited

Loading

quadcopterman commented May 16, 2024

matteosz left a comment

matteosz commented May 23, 2024

sonarcloud bot commented May 29, 2024

sonarcloud bot commented May 29, 2024

sonarcloud bot commented May 29, 2024

sonarcloud bot commented May 29, 2024

sonarcloud bot commented May 29, 2024

matteosz left a comment

Protocol part of the federation authentication on FE2 #1838

Protocol part of the federation authentication on FE2 #1838

Conversation

quadcopterman commented May 1, 2024 • edited Loading

github-actions bot commented May 1, 2024

Pull reviewers stats

Kaz-ookid left a comment

Choose a reason for hiding this comment

Kaz-ookid commented May 16, 2024 • edited Loading

quadcopterman commented May 16, 2024

matteosz left a comment

Choose a reason for hiding this comment

matteosz commented May 23, 2024

sonarcloud bot commented May 29, 2024

Quality Gate passed for 'PoP - PoPCHA-Web-Client'

sonarcloud bot commented May 29, 2024

Quality Gate passed for 'PoP - Be2-Scala'

sonarcloud bot commented May 29, 2024

Quality Gate passed for 'PoP - Be1-Go'

sonarcloud bot commented May 29, 2024

Quality Gate passed for 'PoP - Fe1-Web'

sonarcloud bot commented May 29, 2024

Quality Gate passed for 'PoP - Fe2-Android'

matteosz left a comment

Choose a reason for hiding this comment

quadcopterman commented May 1, 2024 •

edited

Loading

Kaz-ookid commented May 16, 2024 •

edited

Loading