Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed copy clipoboard button appearing black on darkmode #1833

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

Kaz-ookid
Copy link
Contributor

Addressing issue #1828

newly added button was not turning white when phone is set to darkmode

@Kaz-ookid Kaz-ookid requested a review from a team as a code owner April 29, 2024 21:05
Copy link

Pull reviewers stats

Stats of the last 30 days for popstellar:

User Total reviews Time to review Total comments
K1li4nL
🥇
6
▀▀▀
4d 22h 16m
▀▀
25
▀▀▀▀▀▀
matteosz
🥈
4
▀▀
1d 22h 20m
7
▀▀
arnauds5
🥉
2
13h 26m
0
t1b00
2
7d 16h 20m
▀▀
4
simone-kalbermatter
2
1d 14h 29m
2
onsriahi14
2
5d 5h 47m
▀▀
1
Tyratox
1
4d 1h 48m
3
1florentin
1
2h 20m
0
sgueissa
1
25m
0
MariemBaccari
1
16h 14m
0
DanielTavaresA
1
3d 22h 24m
2
⚡️ Pull request stats

@Kaz-ookid Kaz-ookid self-assigned this Apr 29, 2024
@Kaz-ookid Kaz-ookid linked an issue Apr 29, 2024 that may be closed by this pull request
Copy link

sonarcloud bot commented Apr 29, 2024

Quality Gate Passed Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Apr 29, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be2-Scala'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Apr 29, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be1-Go'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Apr 29, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe1-Web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Apr 29, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe2-Android'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@quadcopterman quadcopterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me !

@Kaz-ookid Kaz-ookid added this pull request to the merge queue Apr 30, 2024
Merged via the queue into master with commit 0252ce0 Apr 30, 2024
19 checks passed
@Kaz-ookid Kaz-ookid deleted the work-fe2-maxime-issue#1828 branch April 30, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Android Copy to Clipboard Buttons invisible in dark mode
3 participants