-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add be1-go implemention of federation authentication part #1827
add be1-go implemention of federation authentication part #1827
Conversation
…aining a FederationChallenge
Pull reviewers statsStats of the last 30 days for popstellar:
|
…t_schema' into work-be1-1florentin-federation_auth_protocol
…t_schema' into work-be1-1florentin-federation_auth_protocol
…ederation-authentication_a' into work-be1-1florentin-federation_auth_protocol
Quality Gate passed for 'PoP - PoPCHA-Web-Client'Issues Measures |
Quality Gate passed for 'PoP - Be2-Scala'Issues Measures |
Quality Gate failed for 'PoP - Be1-Go'Failed conditions |
Quality Gate passed for 'PoP - Fe1-Web'Issues Measures |
Quality Gate passed for 'PoP - Fe2-Android'Issues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LVGTM I have nothing to say you have perfectly fit your feature in the new backend with the same convention as we did. GGWP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved blindly because of time constraints.
Add handler for federation message that do the following (not including verification of sender/etc):
The channel "/root/<loa_id>/federation" is used for all the current messages.
The following description was from before the go refactor for the code with last commit: c6b307ff6ee4b4822514ac890e6ca2a2698e091d
Implements some message handlers of the federation authentication (FederationResult is being done by Florentin)- processChallengeRequest: generate a new challenge and send it back to the organizer
- processFederationExpect: Store informations about the other organization, with the expected challenge.
- processFederationInit: Store informations about the other organization, initiate a ws connection to the other server, then publish the FederationChallenge on the other server's federation channel
- processFederationChallenge: check that the challenge is valid, send federation result
A channel "/root/<lao_id>/federation" is created when a lao is created.
Informations about the other organization are stored in a map, such that it could be possible to handle multiple organizations. The public key of the organizer of the other lao is used as the key.
The challenge field of the json schema of FederationInit was changed from only a challenge to a general message containing a FederationChallenge. So that it's possible to send a FederationChallenge signed by the organizer (not the server)