jsonRPC handle of rumor msg in scala backend #1799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t1b00
reviewed
Apr 14, 2024
be2-scala/src/main/scala/ch/epfl/pop/json/HighLevelProtocol.scala
Outdated
Show resolved
Hide resolved
t1b00
requested changes
Apr 14, 2024
onsriahi14
reviewed
Apr 14, 2024
be2-scala/src/main/scala/ch/epfl/pop/json/HighLevelProtocol.scala
Outdated
Show resolved
Hide resolved
K1li4nL
requested changes
Apr 14, 2024
be2-scala/src/main/scala/ch/epfl/pop/model/network/method/Rumor.scala
Outdated
Show resolved
Hide resolved
be2-scala/src/test/scala/util/examples/json/rumor/exampleRumor.scala
Outdated
Show resolved
Hide resolved
K1li4nL
previously approved these changes
Apr 17, 2024
|
|
|
|
|
t1b00
approved these changes
Apr 18, 2024
K1li4nL
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on PR #1789 , handles and tests the new rumor jsonRPC message.
Can read an incoming rumor jsonRPC, convert it to a Rumor object containing its respective objects : - serverId : PublicKey, rumorId : Int, messages : Map[Channel, List[Messages]]. Can also do the reverse operation and write to a jsonRPC Rumor