Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE2]: Enum refactoring #1763

Merged
merged 9 commits into from
Mar 24, 2024
Merged

[BE2]: Enum refactoring #1763

merged 9 commits into from
Mar 24, 2024

Conversation

t1b00
Copy link
Contributor

@t1b00 t1b00 commented Feb 28, 2024

Refactored enums into parametrized enums

@t1b00 t1b00 requested a review from a team as a code owner February 28, 2024 10:21
@CLAassistant
Copy link

CLAassistant commented Feb 28, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions GitHub Actions
Copy link

Pull reviewers stats

Stats of the last 30 days for popstellar:

User Total reviews Time to review Total comments
pierluca
🥇		 6
▀▀▀		 5d 21h 36m
▀▀▀▀		 10
▀▀▀▀▀
MariemBaccari
🥈		 4
▀▀		 1d 17h 15m
▀		 1
▀
sgueissa
🥉		 2
▀		 4d 21h 25m
▀▀▀		 8
▀▀▀▀
jbsv
 2
▀		 1d 7h 33m
▀		 0
arnauds5
 1
▀		 6h 55m
 0
osm-alt
 1
▀		 5h 52m
 0
ljankoschek
 1
▀		 20h 9m
▀		 0
K1li4nL
 1
▀		 18m
 0
emonnin-epfl
 1
▀		 6h 45m
 1
▀

@K1li4nL K1li4nL linked an issue Mar 19, 2024 that may be closed by this pull request
[BE2]: Refactoring enums to avoid string comparisons #1757
Closed
@onsriahi14 onsriahi14 self-requested a review March 20, 2024 00:41
onsriahi14
onsriahi14 previously approved these changes Mar 20, 2024
View reviewed changes
K1li4nL
K1li4nL requested changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@K1li4nL K1li4nL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work and nice coverage ! Just a few things I believe should be changed (can be discussed though)

be2-scala/src/test/scala/ch/epfl/pop/json/HighLevelProtocolSuite.scala Outdated Show resolved Hide resolved
be2-scala/src/test/scala/ch/epfl/pop/json/MessageDataProtocolSuite.scala Outdated Show resolved Hide resolved
be2-scala/src/test/scala/ch/epfl/pop/json/MessageDataProtocolSuite.scala Outdated Show resolved Hide resolved
be2-scala/src/test/scala/ch/epfl/pop/json/MessageDataProtocolSuite.scala Outdated Show resolved Hide resolved
be2-scala/src/test/scala/ch/epfl/pop/json/MessageDataProtocolSuite.scala Outdated Show resolved Hide resolved
@t1b00 t1b00 requested a review from K1li4nL March 24, 2024 17:47
@K1li4nL K1li4nL changed the title Work be2 thibault enum refactor [BE2]: Enum refactoring Mar 24, 2024
K1li4nL
K1li4nL requested changes Mar 24, 2024
View reviewed changes
Copy link
Contributor

@K1li4nL K1li4nL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nitpick and a last test that need to be broken in two, after that all should be good for me !

be2-scala/src/test/scala/ch/epfl/pop/json/MessageDataProtocolSuite.scala Outdated Show resolved Hide resolved
be2-scala/src/test/scala/ch/epfl/pop/json/HighLevelProtocolSuite.scala Outdated Show resolved Hide resolved
@t1b00
Split MethodType tests and added INVALID method type rejection in met…
e5f2244 
…hodTypeFormat. Inlined some variables in MessageDataProtocolSuite
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 24, 2024

Quality Gate Passed Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 24, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be2-Scala'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
76.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 24, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be1-Go'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 24, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe2-Android'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 24, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe1-Web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

K1li4nL
K1li4nL approved these changes Mar 24, 2024
View reviewed changes
Copy link
Contributor

@K1li4nL K1li4nL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@t1b00 t1b00 merged commit 7ab4c2c into master Mar 24, 2024
18 checks passed
@t1b00 t1b00 deleted the work-be2-thibault-enum-refactor branch March 24, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@K1li4nL K1li4nL K1li4nL approved these changes

@onsriahi14 onsriahi14 onsriahi14 left review comments

Assignees
No one assigned
Labels
be2-scala
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BE2]: Refactoring enums to avoid string comparisons
4 participants
@t1b00 @CLAassistant @onsriahi14 @K1li4nL