-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed default connection URL from wss to ws #1755
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
…k-fe1-omajzoub
Quality Gate passed for 'PoP - PoPCHA-Web-Client'Issues Measures |
Quality Gate passed for 'PoP - Be1-Go'Issues Measures |
Quality Gate passed for 'PoP - Be2-Scala'Issues Measures |
Quality Gate passed for 'PoP - Fe2-Android'Issues Measures |
Quality Gate passed for 'PoP - Fe1-Web'Issues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too :)
Since the backend server currently uses Websockets without TLS, I changed the default URL for the user in fe1 from wss://127.0.0.1:9000/client to ws://127.0.0.1:9000/client.
ConnectConfirm.tsx, Launch.tsx, ConnectConfirm.test.tsx.snap, and Launch.test.tsx.snap have been modified to incorporate this modification.