Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed default connection URL from wss to ws #1755

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Conversation

osm-alt
Copy link
Contributor

@osm-alt osm-alt commented Feb 25, 2024

Since the backend server currently uses Websockets without TLS, I changed the default URL for the user in fe1 from wss://127.0.0.1:9000/client to ws://127.0.0.1:9000/client.
ConnectConfirm.tsx, Launch.tsx, ConnectConfirm.test.tsx.snap, and Launch.test.tsx.snap have been modified to incorporate this modification.

@osm-alt osm-alt requested a review from a team as a code owner February 25, 2024 14:20
@CLAassistant
Copy link

CLAassistant commented Feb 25, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

Pull reviewers stats

Stats of the last 30 days for popstellar:

User Total reviews Time to review Total comments
pierluca
🥇
5
▀▀▀▀▀
6d 7h 35m
▀▀▀▀▀▀
10
▀▀▀▀▀▀▀
jbsv
🥈
2
▀▀
1d 7h 33m
0
sgueissa
🥉
1
1h 17m
3
▀▀
MariemBaccari
1
3d 54m
▀▀▀
0
K1li4nL
1
18m
0
emonnin-epfl
1
6h 45m
1

Copy link
Contributor

@ljankoschek ljankoschek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@osm-alt osm-alt requested a review from Tyratox February 26, 2024 12:55
Copy link

sonarcloud bot commented Feb 26, 2024

Quality Gate Passed Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Feb 26, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be1-Go'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Feb 26, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be2-Scala'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Feb 26, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe2-Android'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Feb 26, 2024

Copy link
Contributor

@pierluca pierluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too :)

@pierluca pierluca merged commit 1c87e12 into master Feb 27, 2024
18 checks passed
@pierluca pierluca deleted the work-fe1-omajzoub branch February 27, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants