Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE2]: Fix social in multi-server context #1738

Merged
merged 4 commits into from
Feb 8, 2024

Conversation

K1li4nL
Copy link
Contributor

@K1li4nL K1li4nL commented Feb 8, 2024

Chirps notify_add is a server generated message in reaction to a chirp_add, it is not necessary to store it in the database. It causes issues when connecting a go and scala servers together. This pr fixes that.

Copy link

github-actions bot commented Feb 8, 2024

Pull reviewers stats

Stats of the last 30 days for popstellar:

User Total reviews Time to review Total comments
pierluca
🥇
2
▀▀▀
11d 5h 54m
▀▀▀▀▀
2
▀▀▀▀▀▀▀
jbsv
🥈
2
▀▀▀
7d 10h 45m
▀▀▀
1
▀▀▀
MariemBaccari
🥉
1
▀▀
3d 54m
0
K1li4nL
1
▀▀
18m
0

Copy link

sonarcloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe2-Android'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Feb 8, 2024

Copy link

sonarcloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be1-Go'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe1-Web'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@K1li4nL K1li4nL marked this pull request as ready for review February 8, 2024 13:25
@K1li4nL K1li4nL requested a review from a team as a code owner February 8, 2024 13:25
@pierluca pierluca merged commit d5a7fe3 into master Feb 8, 2024
19 checks passed
@pierluca pierluca deleted the work-be2-Kilian-Fix-social branch February 8, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants