Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kotlin migration - part 2 #1728

Merged
merged 19 commits into from
Feb 5, 2024
Merged

Kotlin migration - part 2 #1728

merged 19 commits into from
Feb 5, 2024

Conversation

matteosz
Copy link
Contributor

@matteosz matteosz commented Jan 18, 2024 •
edited
Loading

Second part of the Kotlin migration. This PR migrates the rest of the files except for the \tests and \src\ui folders

@matteosz matteosz self-assigned this Jan 18, 2024
@github-actions GitHub Actions
Copy link

Pull reviewers stats

Stats of the last 30 days for popstellar:

User Total reviews Time to review Total comments
pierluca
🥇		 1
▀▀▀▀▀▀▀▀▀▀		 11d 4h 29m
▀▀▀▀▀▀▀▀▀▀		 16
▀▀▀▀▀▀▀▀▀▀

@matteosz matteosz marked this pull request as ready for review January 25, 2024 17:01
@matteosz matteosz requested a review from a team as a code owner January 25, 2024 17:01
jbsv
jbsv previously approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@jbsv jbsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a lot of changes. I did what I could but couldn't finish it.
I just peeked one comment that is probably a forgotten one.

fe2-android/app/src/main/java/com/github/dedis/popstellar/di/DataRegistryModule.kt Outdated Show resolved Hide resolved
matteosz
matteosz commented Jan 26, 2024
View reviewed changes
Copy link
Contributor Author

@matteosz matteosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review

fe2-android/app/src/main/java/com/github/dedis/popstellar/di/DataRegistryModule.kt Show resolved Hide resolved
fe2-android/app/src/main/java/com/github/dedis/popstellar/model/Role.kt Outdated Show resolved Hide resolved
...id/app/src/main/java/com/github/dedis/popstellar/model/network/method/message/data/Action.kt Outdated Show resolved Hide resolved
.../src/main/java/com/github/dedis/popstellar/model/network/method/message/data/DataRegistry.kt Outdated Show resolved Hide resolved
...a/com/github/dedis/popstellar/model/network/method/message/data/consensus/ConsensusAccept.kt Outdated Show resolved Hide resolved
...ain/java/com/github/dedis/popstellar/model/network/method/message/data/digitalcash/Output.kt Outdated Show resolved Hide resolved
fe2-android/app/src/main/java/com/github/dedis/popstellar/model/qrcode/PoPCHAQRCode.kt Outdated Show resolved Hide resolved
@matteosz matteosz force-pushed the work-fe2-matteo-kotlin-migration6 branch from c09d197 to 93bc297 Compare January 27, 2024 10:31
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 27, 2024

Quality Gate Passed Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 27, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be1-Go'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 27, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be2-Scala'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 27, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe2-Android'

The SonarCloud Quality Gate passed, but some issues were introduced.

23 New issues
0 Security Hotspots
76.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 27, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe1-Web'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jbsv
Copy link
Contributor

jbsv commented Feb 4, 2024 •
edited
Loading

Happy to approve as is, but can you please add a separate PR to reduce the "23 new issues on FE2" ?

jbsv
jbsv approved these changes Feb 4, 2024
View reviewed changes
Copy link
Contributor

@jbsv jbsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge if this code has been tested. Do you confirm that the FE2 app still runs in Android Studio?

pierluca
pierluca approved these changes Feb 4, 2024
View reviewed changes
Copy link
Contributor

@pierluca pierluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't review everything (for obvious reasons), but randomly sampled files look good 👍

@matteosz matteosz merged commit 08fca38 into master Feb 5, 2024
18 checks passed
@matteosz matteosz deleted the work-fe2-matteo-kotlin-migration6 branch February 5, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbsv jbsv jbsv approved these changes

@pierluca pierluca pierluca approved these changes

Assignees

@matteosz matteosz

Labels
fe2-android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matteosz @jbsv @pierluca