Refactoring consensus feature #1713
Conversation
Pull reviewers statsStats of the last 30 days for popstellar:
|
There was a problem hiding this comment.
I've reviewed a good chunk of it but I can't say much about some parts. Could you also have a look @simone-kalbermatter ? :)
|
[PoP - PoPCHA-Web-Client] Kudos, SonarCloud Quality Gate passed!
|
|
[PoP - Be1-Go] Kudos, SonarCloud Quality Gate passed!
|
|
[PoP - Be2-Scala] Kudos, SonarCloud Quality Gate passed!
|
|
[PoP - Fe2-Android] Kudos, SonarCloud Quality Gate passed! |
|
[PoP - Fe1-Web] Kudos, SonarCloud Quality Gate passed!
|
| // TODO uncomment that when consensus does not rely on call by reference | ||
| // Optional<ElectInstance> optional = lao.getElectInstance(messageId); | ||
| // return optional.map(ElectInstance::new); // If empty returns empty optional, if not | ||
| // returns optional with copy of retrieved ElectInstance |
There was a problem hiding this comment.
Yes it is, I'll update it
…oring' into work-fe2-matteo-consensus-refactoring merge commmit
|
|
|
|
|
This PR fixes #1374 by removing the consensus feature from the LAO object, using instead a dedicated repository.