Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed response mode handling #1674

Merged
merged 1 commit into from
Jun 20, 2023
Merged

fixed response mode handling #1674

merged 1 commit into from
Jun 20, 2023

Conversation

Nazianzenov
Copy link
Contributor

  • response mode can be selected between fragment and query
  • the server was not handling correctly the fragment response mode, and was always using the query one.

@Nazianzenov
fixed response mode handling
658f83f 
* response mode can be selected between fragment and query
* the server was not handling correctly the fragment response mode, and was always using the query one.
@Nazianzenov Nazianzenov self-assigned this Jun 20, 2023
@Nazianzenov Nazianzenov requested a review from a team as a code owner June 20, 2023 10:18
@sonarcloud
Copy link

sonarcloud bot commented Jun 20, 2023

[PoP - PoPCHA-Web-Client] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jun 20, 2023

[PoP - Be2-Scala] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jun 20, 2023

[PoP - Fe1-Web] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jun 20, 2023

[PoP - Be1-Go] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

88.9% 88.9% Coverage
0.0% 0.0% Duplication

MariemBaccari
MariemBaccari approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@MariemBaccari MariemBaccari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jbsv
jbsv approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@jbsv jbsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good To Me

@sonarcloud
Copy link

sonarcloud bot commented Jun 20, 2023

[PoP - Fe2-Android] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Nazianzenov Nazianzenov merged commit 9006a6d into master Jun 20, 2023
@Nazianzenov Nazianzenov deleted the work-be1-nazianze-popcha-responsemode branch June 20, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbsv jbsv jbsv approved these changes

@MariemBaccari MariemBaccari MariemBaccari approved these changes

@pierluca pierluca Awaiting requested review from pierluca

Assignees

@Nazianzenov Nazianzenov

Labels
be1-go popcha
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nazianzenov @MariemBaccari @jbsv