Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build info over left menu #1651

Merged
merged 4 commits into from
Jun 7, 2023
Merged

Fix build info over left menu #1651

merged 4 commits into from
Jun 7, 2023

Conversation

MeKHell
Copy link
Contributor

@MeKHell MeKHell commented Jun 7, 2023

Fix #1592

This PR puts the Build infos in the header background, so that they do not overlap anymore with the left menu.
Without menu:
image

With menu:
image

@MeKHell MeKHell requested a review from a team as a code owner June 7, 2023 09:14
@MeKHell MeKHell self-assigned this Jun 7, 2023
@MeKHell MeKHell linked an issue Jun 7, 2023 that may be closed by this pull request
[BUG] Release version number overlaps side menu #1592
Closed
@sonarcloud
Copy link

sonarcloud bot commented Jun 7, 2023

[PoP - Be1-Go] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jun 7, 2023

[PoP - Be2-Scala] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jun 7, 2023

[PoP - Fe2-Android] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jun 7, 2023

[PoP - Fe1-Web] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@MeKHell MeKHell changed the title Work fe1 greub fix build info over left menu Fix build info over left menu Jun 7, 2023
Xelowak
Xelowak approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@Xelowak Xelowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MeKHell MeKHell merged commit c2940af into release-2023-spring Jun 7, 2023
@MeKHell MeKHell deleted the work-fe1-greub-fix-BuildInfo-over-left-menu branch June 7, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelowak Xelowak Xelowak approved these changes

@dayan9265 dayan9265 Awaiting requested review from dayan9265

@Tyratox Tyratox Awaiting requested review from Tyratox

Assignees

@MeKHell MeKHell

Labels
bug-fix Fixes a bug fe1-web ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Release version number overlaps side menu
2 participants
@MeKHell @Xelowak