Highlight personal token rollcall + sort rollcall #1640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-nico-sorted-attendee-list
…st' into work-fe1-dmassonn-highlight-personal-token-rollcall
MeKHell
requested changes
Jun 7, 2023
Co-authored-by: MeKHell <42808302+MeKHell@users.noreply.github.com>
|
[PoP - Be2-Scala] Kudos, SonarCloud Quality Gate passed!
|
|
[PoP - Fe2-Android] Kudos, SonarCloud Quality Gate passed!
|
|
[PoP - Fe1-Web] SonarCloud Quality Gate failed. |
|
[PoP - Be1-Go] Kudos, SonarCloud Quality Gate passed!
|
Xelowak
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the changes of @Tyratox to make sure that the list is sorted when sending it to the back-end, currently if it is not the case when receiving a non sorted list, it just creates a warning. Later when back-end will make sure it is sorted, we could make it throw if it is not sorted.
This PR also highlights personal token, to make it easier for the user to know his token and also if he is in the current roll call, currently it looks like this (in light blue being my token):