Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Karate Part 3 #1634

Merged
merged 15 commits into from
Jun 7, 2023
Merged

Refactor Karate Part 3 #1634

merged 15 commits into from
Jun 7, 2023

Conversation

simone-kalbermatter
Copy link
Contributor

@simone-kalbermatter simone-kalbermatter commented Jun 3, 2023 •
edited
Loading

This PR refactors the following features:

  • electionSetup.feature
  • electionOpen.feature
  • castVote.feature
  • electionEnd.feature
  • update.feature
  • transaction.feature
  • hearbeat.feature

The hearbeat feature was split into 2 features, heartbeat and getMessagesById and for both some more tests were added.

The Transaction class currently only supports one transaction and does not keep track of previous transactions. This causes one failing test in transaction.feature: Transfer valid amount should work. I created an issue for this here: #1645

@simone-kalbermatter simone-kalbermatter changed the base branch from work-simone-refactor-karate-feature to master June 3, 2023 22:24
@simone-kalbermatter simone-kalbermatter changed the base branch from master to work-simone-refactor-karate-feature June 3, 2023 22:25
@simone-kalbermatter simone-kalbermatter self-assigned this Jun 4, 2023
@simone-kalbermatter simone-kalbermatter added prod-ready Production Ready related pull requests fe2-android labels Jun 4, 2023
@simone-kalbermatter simone-kalbermatter marked this pull request as ready for review June 5, 2023 20:48
@simone-kalbermatter simone-kalbermatter requested a review from a team as a code owner June 5, 2023 20:48
matteosz
matteosz approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@matteosz matteosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice and clean work, also very well documentated! 😄

GabrielFleischer
GabrielFleischer requested changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@GabrielFleischer GabrielFleischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very great work !

I found some small things here and there, nothing too big.

tests/karate/src/test/java/be/decentralizedCom/getMessagesById.feature Outdated Show resolved Hide resolved
tests/karate/src/test/java/be/decentralizedCom/getMessagesById.feature Show resolved Hide resolved
tests/karate/src/test/java/be/digitalCash/transaction.feature Outdated Show resolved Hide resolved
tests/karate/src/test/java/be/model/Transaction.java Outdated Show resolved Hide resolved
tests/karate/src/test/java/be/model/Transaction.java Outdated Show resolved Hide resolved
GabrielFleischer
GabrielFleischer requested changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@GabrielFleischer GabrielFleischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very great work !

I found some small things here and there, nothing too big.

@sonarcloud
Copy link

sonarcloud bot commented Jun 7, 2023

[PoP - PoPCHA-Web-Client] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jun 7, 2023

[PoP - Be2-Scala] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jun 7, 2023

[PoP - Be1-Go] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jun 7, 2023

[PoP - Fe2-Android] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jun 7, 2023

[PoP - Fe1-Web] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

GabrielFleischer
GabrielFleischer approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@GabrielFleischer GabrielFleischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simone-kalbermatter simone-kalbermatter merged commit d79b108 into work-simone-refactor-karate-feature Jun 7, 2023
@simone-kalbermatter simone-kalbermatter deleted the work-simone-refactor-karate2 branch June 7, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matteosz matteosz matteosz approved these changes

@GabrielFleischer GabrielFleischer GabrielFleischer approved these changes

Assignees

@simone-kalbermatter simone-kalbermatter

Labels
fe2-android prod-ready Production Ready related pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simone-kalbermatter @GabrielFleischer @matteosz