Extended multi connection to multiple greet laos #1613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[PoP - Be2-Scala] Kudos, SonarCloud Quality Gate passed!
|
|
[PoP - Be1-Go] Kudos, SonarCloud Quality Gate passed!
|
|
[PoP - Fe2-Android] Kudos, SonarCloud Quality Gate passed! |
|
[PoP - Fe1-Web] Kudos, SonarCloud Quality Gate passed!
|
simone-kalbermatter
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the current multiconnection to also connect to servers which join later.
As the backends have implemented a dynamic server configuration, they are going to send a new GreetLao when a new peer joins. So far, the current multiconnection was only connecting to the peers in the very first greet lao, maintaining static the servers set. By this change now we process each greetlao and we connect to all the peers we have not been connected yet, allowing to connect to new servers joining the network.