Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed social media reaction bugs #1607

Merged
merged 3 commits into from
May 27, 2023
Merged

Fixed social media reaction bugs #1607

merged 3 commits into from
May 27, 2023

Conversation

matteosz
Copy link
Contributor

This PR resolves #1603 and resolves #1606.

@matteosz matteosz self-assigned this May 25, 2023
@matteosz matteosz marked this pull request as ready for review May 25, 2023 22:12
@matteosz matteosz requested a review from a team as a code owner May 25, 2023 22:12
@sonarcloud
Copy link

sonarcloud bot commented May 25, 2023

[PoP - Be2-Scala] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented May 25, 2023

[PoP - Be1-Go] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented May 25, 2023

[PoP - Fe1-Web] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented May 26, 2023

[PoP - Fe2-Android] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

simone-kalbermatter
simone-kalbermatter approved these changes May 26, 2023
View reviewed changes
Copy link
Contributor

@simone-kalbermatter simone-kalbermatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Warhedgehog
Warhedgehog approved these changes May 27, 2023
View reviewed changes
Copy link
Contributor

@Warhedgehog Warhedgehog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matteosz matteosz merged commit 61f6125 into master May 27, 2023
@matteosz matteosz deleted the work-fe2-matteo-emoji-fix branch May 27, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simone-kalbermatter simone-kalbermatter simone-kalbermatter approved these changes

@Warhedgehog Warhedgehog Warhedgehog approved these changes

Assignees

@matteosz matteosz

Labels
bug-fix Fixes a bug fe2-android
Projects
None yet
Milestone
No milestone
3 participants
@matteosz @Warhedgehog @simone-kalbermatter