Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server.go and server_test.go refactor #1588

Merged
merged 1 commit into from
May 24, 2023
Merged

server.go and server_test.go refactor #1588

merged 1 commit into from
May 24, 2023

Conversation

Nazianzenov
Copy link
Contributor

  • response type is now id_token
  • setting host and scheme for the URL contained in the QR Code (server.go)

@Nazianzenov
fixing server:
2dd8582 
* response type is now id_token
* setting host and scheme for the URL contained in the QR Code (server.go)
@Nazianzenov Nazianzenov self-assigned this May 23, 2023
@Nazianzenov Nazianzenov requested a review from a team as a code owner May 23, 2023 10:39
Nazianzenov
Nazianzenov commented May 23, 2023
View reviewed changes
be1-go/popcha/server.go
@@ -37,7 +37,7 @@ const (
tokenLifeTimeHour = 24

// qrSize size of QRCode SVG
qrSize = 10
qrSize = 9
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was change for aesthetic purpose (zooming too much with size 10 would make the QR Code way out of frame)

@sonarcloud
Copy link

sonarcloud bot commented May 23, 2023

[PoP - Be2-Scala] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented May 23, 2023

[PoP - Be1-Go] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented May 23, 2023

[PoP - Fe2-Android] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented May 23, 2023

[PoP - Fe1-Web] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

MariemBaccari
MariemBaccari approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@MariemBaccari MariemBaccari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a small PR with clean / clear code. LGTM.

Anghul
Anghul approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@Anghul Anghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment about a small detail, but LGTM for the rest

be1-go/popcha/server.go
data := req.Host + req.URL.String()
qrCode, err := qr.Encode(data, qr.M, qr.Auto)
// add the scheme and host to the URL

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useless line break here

@Nazianzenov Nazianzenov merged commit 0686064 into master May 24, 2023
@Nazianzenov Nazianzenov deleted the work-be1-nazianze-popcha-smallfix branch May 24, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anghul Anghul Anghul approved these changes

@MariemBaccari MariemBaccari MariemBaccari approved these changes

Assignees

@Nazianzenov Nazianzenov

Labels
be1-go popcha
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nazianzenov @MariemBaccari @Anghul