Add config file watch service #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K1li4nL
force-pushed
the
work-be2-lauener-add-peers-greetLao
branch
from
7f0939c
to
db5c785
Compare
K1li4nL
force-pushed
the
work-be2-lauener-add-config-file-watch
branch
2 times, most recently
from
39ed6f5
to
af53079
Compare
K1li4nL
force-pushed
the
work-be2-lauener-add-peers-greetLao
branch
from
2342b8b
to
f293b83
Compare
K1li4nL
force-pushed
the
work-be2-lauener-add-config-file-watch
branch
from
af53079
to
88f603a
Compare
Jharaxus
requested changes
May 20, 2023
be2-scala/src/main/scala/ch/epfl/pop/decentralized/Monitor.scala
Outdated
Show resolved
Hide resolved
be2-scala/src/test/scala/ch/epfl/pop/decentralized/MonitorSuite.scala
Outdated
Show resolved
Hide resolved
K1li4nL
force-pushed
the
work-be2-lauener-add-config-file-watch
branch
from
88f603a
to
454a91b
Compare
Jharaxus
approved these changes
May 21, 2023
|
[PoP - Be2-Scala] Kudos, SonarCloud Quality Gate passed! |
|
[PoP - Be1-Go] Kudos, SonarCloud Quality Gate passed!
|
|
[PoP - Fe2-Android] Kudos, SonarCloud Quality Gate passed!
|
|
[PoP - Fe1-Web] Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds the ability for the system to react on the fly to changes in the config files added in #1519.
Limitations: Without greet_server implementation we are still susceptible to having double connections (A to B and B to A, over two websockets).