Final merge PR for drand/kyber #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added index of signature
returning err only if not enough valid partials
CluEleSsUK
reviewed
May 23, 2024
pairing/circl_bls12381/adapter.go
Outdated
| // still preserves the properties of the pairing (e.g. the Pair function). | ||
| // | ||
| // It's important to note that the Point function will generate a point | ||
| // compatible with public keys only (group G2) where the signature must be |
There was a problem hiding this comment.
is this not the reverse of the standard case? It seems that most bls libs put pub keys on G1 and sigs on G2. In drand we do the opposite.
It seems circl supports both
* Moved scheme.go and threshold.go into internals and uncommented bls_test.go * Removed nerr++ in favor of len(errors) * Changed the path for test * Sorting imports * Update bn256 from cloudflare's changes * Added the bn256/hash.go and its tests
* Removed nonce from Rabin VSS * Removed nonce from Pedersen VSS
* Switched back to matrix in CI * Fixed go version * Rm not working manual go version for alpine * Removed debugging + fixed go version on x86 + go version to 1.21-1.22 * Unified test workflow * Upgrade go version + rm matrix from permission * Added concurrency check back
* BREAKING API change: Refactored curve packages nist -> p256 * BREAKING API change: Changed names from 25519 to ed25519 --------- Co-authored-by: Yolan Romailler <anomalroil@users.noreply.github.com>
* Add rfc9380 test vectors * Add expand_message_xmd * Add test vector sha512 * Add Elligator2 for curve25519 * Add mapToCurve for edwards25519 * Add domain separator as param * Set to use sha512 by default * Extract repeated inputs in test * Add test * Use proper byte to fe * Use constant fe computed manually * Add test hashToField * Pad array * Add Hash() test * Add doc for new fe functions * Add inline operations comments * Add rfc ref * Add fe conversion test * Add long dst support + tests * Add missing mod * Add expandMessageXOF * Add readme with code for test vector gen. * Add test vector + more complex property test * Force use of domain separator * Add domainSep. check expand xof --------- Co-authored-by: Yolan Romailler <anomalroil@users.noreply.github.com>
* Added circl and kilic implementation of bls12381 + benchmarks * Added deserialization tests compressed vectors +more comments * Fix IBE in the drand merge (#514) * Add ByteOrder() function + constant from int.go * Update circl_bls12381 and edwards25519 scalars * Add Order() to the scalar interface * Adapt IBE to make it general * Fix dkg bug (#515) * BugFix: use array index instead of node index * Fix endianess bool * Add tests for endianess * Fixed deserialization tests + circl issue * Removed groupchecker iface * Added back circl deserialization test (cloudflare/circl#499) * Since Go 1.21 go mod tidy require the go directive to match the highest of our dependencies --------- Co-authored-by: Kilian <79536516+K1li4nL@users.noreply.github.com> Co-authored-by: Yolan Romailler <anomalroil@users.noreply.github.com>
* Expose error types * Add dec challenge verification * Move globalChallenge check to VerifyEncShare * Use Horner method to compute commitments * Change computeCommitments signature * Remove unused error
* Added benchmark app + deployment workflow * Added data.json and improved app with logo * Improved benchmark readme --------- Co-authored-by: Yolan Romailler <anomalroil@users.noreply.github.com>
* Setup golangci action * Enable golangci-lint contextcheck * Add missing error handling * Rename unused parameters * ignore IDE .idea * Ignore interface bloat in group.go * Fix some formatting * Add error handling * Fix asalint * minor fixes * Add false-positive exception * Add line length exception * Correct capitalization * Fix lint issues package bn256 * Fix lint issues package eddsa * Fix lint issues package util * Fix lint issues package keccak * Fix lint issues package int * Fix lint issues package blake2x[s, b] * Fix lint issues package curve25519 * Fix lint issues package shuffle * Fix lint issues package dleq * Fix lint issues package share * Fix lint issues package curve25519 * Fix lint issues package anon * Fix lint issues package cosi * Fix lint issues package ecies * Fix lint issues dkg-rabin * Fix most lint issues package proof * Fix most lint issues package nist * Fix lint issues sign * Fix most lint issues share * Fix lint issues share * Reduce cogn. complexity * Fix linter issues package edwards25519 * relax golangci rules * Fix last linter error in group * More linter fix * Rename unused parameters * Divide large test * Fix new lint error shuffle * Fix lint error encoding * Make initBasePoint() a method of curve25519 * Fix forgotten conflict * Add back golangci rules * Add error handling * Remove println * Simplify if-else chain * Simplify function * Replace prints * Remove unused * Harmonize receivers name * Simplify if-else * Fix lint issue share package * Ignore dup, lll and funlen for certain files * Lint fix for pairing package * Lint fix for sign package * Lint fix curve25519 * Lint fix xof package * Update golangci rules * Better var name * Add missing error handling * Update golangci rules * Remove useless nolint * ignore / fix lint errors * Allow capital var name for point convention * Make points name capital * Errors fix * Typos * Remove unused lint rules * Remove unnecessary checks * Export dleq errors * Rename test file * Export cast error * Wrap errors * Minor refactoring * Export errors * Multiple fix * Fix ibe lint errors * Add lint exceptions * Fix mistake fe_test * Clean up
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new PR for #509 to allow everyone to work against the
drandmergebranch on the Dedis repo.