Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update CI to allow PR from forked repo #476

Merged
merged 1 commit into from
Nov 8, 2022
Merged

update CI to allow PR from forked repo #476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .github/workflows/go_lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,20 +3,24 @@ name: Go lint
on:
push:
branches: [ master ]
pull_request:
pull_request_target:
types: [opened, synchronize, reopened]

jobs:

lint:
runs-on: ubuntu-latest
steps:
- name: Use go >= 1.13
- name: Set up Go ^1.13
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might want to move to 1.19 soonish, don't we ?

uses: actions/setup-go@v3
with:
go-version: '>=1.13'
go-version: ^1.13

- name: Check out code into the Go module directory
uses: actions/checkout@v3
with:
ref: ${{ github.event.pull_request.head.sha }}
fetch-depth: 0

- name: Tidy
run: go mod tidy && [ -z "$(git status -s)" ]
Expand Down
48 changes: 38 additions & 10 deletions .github/workflows/go_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,37 +3,65 @@ name: Go test
on:
push:
branches: [ master ]
pull_request:
pull_request_target:
types: [opened, synchronize, reopened]

jobs:
permission:
runs-on: ubuntu-latest
steps:
- name: Add comment if PR permission failed
if: ${{ !contains(github.event.pull_request.labels.*.name, 'safe PR') }}
uses: actions/github-script@v3
with:
github-token: ${{secrets.GITHUB_TOKEN}}
script: |
github.issues.createComment({
issue_number: context.issue.number,
owner: context.repo.owner,
repo: context.repo.repo,
body: '🔒 Could not start CI tests due to missing *safe PR* label. Please contact one of the repo maintainers.'
})
- name: Check permission
if: ${{ !contains(github.event.pull_request.labels.*.name, 'safe PR') }}
run: |
echo "::error:: Could not start CI tests due to missing *safe PR* label."
exit 1

test:
needs: permission
strategy:
matrix:
platform: [ubuntu-latest, macos-latest, windows-latest]

runs-on: ${{matrix.platform}}

steps:
- name: Use go >= 1.13
- name: Setup go ^1.13
uses: actions/setup-go@v3
with:
go-version: '>=1.13'
go-version: ^1.13

- name: Check out code into the Go module directory
uses: actions/checkout@v3
with:
ref: ${{ github.event.pull_request.head.sha }}
fetch-depth: 0

- name: Test with coverage
if: matrix.platform == 'ubuntu-latest'
run: go test -json -covermode=count -coverprofile=profile.cov ./... > report.json

- name: Test without coverage
if: matrix.platform == 'macos-latest' || matrix.platform == 'windows-latest'
run: go test ./...

- name: Test with coverage
if: matrix.platform == 'ubuntu-latest'
run: go test -json -covermode=count -coverprofile=profile.cov ./... > report.json

- name: Sonarcloud scan
if: matrix.platform == 'ubuntu-latest'
uses: sonarsource/sonarcloud-github-action@master
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
with:
args: >
-Dsonar.organization=dedis
Expand All @@ -43,9 +71,9 @@ jobs:
-Dsonar.c.file.suffixes=-
-Dsonar.cpp.file.suffixes=-
-Dsonar.objc.file.suffixes=-
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
-Dsonar.pullrequest.key=${{ github.event.number }}
-Dsonar.pullrequest.branch=${{ github.head_ref }}
-Dsonar.pullrequest.base=${{ github.event.pull_request.base }}

- name: Send coverage
if: matrix.platform == 'ubuntu-latest'
Expand Down