libdexc: upgrade to v1 dcrdex and initialize market maker #3959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated to tip of release-v1.0 and squashed. I don't expect any more substantive changes. |
JoeGruffins
approved these changes
Aug 26, 2024
modules/dex/libdexc/adapter.go
Outdated
| c.wg.Add(1) | ||
| go func() { | ||
| defer c.wg.Done() | ||
| ccore.Run(c.ctx) | ||
| }() | ||
| <-ccore.Ready() | ||
|
|
||
| mmCM := dex.NewConnectionMaster(c.mm) | ||
| if err := mmCM.ConnectOnce(c.ctx); err != nil { | ||
| return fmt.Errorf("Error connecting market maker") |
alexlyp
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alexlyp I think you were already looking at the upgrade part, but the market maker initialization wasn't obvious. I've also flipped the new switch to use dcrdex branding in Decrediton.
This currently points to the tip of the release-v1.0 branch. This will build with Go 1.23 now. There will be a couple more commits on that branch before release. I can update later, or you can update if you were working separately on the upgrade.