Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binance: update book stream url #3015

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Conversation

buck54321
Copy link
Member

Just the URL update part of the changes discussed and aborted in #2958. I think this was actually the crux of the problem we were seeing, but we also fixed some other stuff in that PR too.

Copy link
Contributor

@martonp martonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

URL should also get updated on unsubscribe.

Copy link
Contributor

@dev-warrior777 dev-warrior777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@buck54321 buck54321 merged commit aee9af7 into decred:master Oct 11, 2024
5 checks passed
buck54321 added a commit to buck54321/dcrdex that referenced this pull request Oct 17, 2024
* update binance book stream url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants