core: lock trade mutex for preimage resp. #2973
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeGruffins
force-pushed
the
lockfindorder
branch
from
417eb6e
to
f965fa4
Compare
JoeGruffins
force-pushed
the
lockfindorder
branch
from
f965fa4
to
e34b453
Compare
|
Obsoleted by #2977 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2964
I think the only way the cancel can become nil is if we received a notification that we already missed the preimage request and so the cancel is revoked, so it would probably be fine to just error, but I'm unsure this is the only reason cancel would be nil here, so locking the trade mutex until we check the csum seems the safest and most straight forward way to deal with this.