Repository navigation
mempool: Prune old vote metadata. - #3805
Merged
Merged
Conversation
dajohi
approved these changes
Oct 5, 2026
jrick
approved these changes
Oct 7, 2026
This updates the test helper for the expected membership in the regular and orphan pools to use the more modern t.Helper instead of the extremely outdated runtime.Caller approach.
The vote metadata that is retained independently of the vote transactions is currently retained indefinitely which means it slowly grows over time without bound as the chain advances. This remedies that by implementing pruning such that vote metadata is removed once the referenced block is sufficiently far behind the current best height. The pruning threshold is aligned with the existing vote retention policy.
This adds extensive tests for vote pruning to include removal from the transaction pool as well as the associated vote metadata. It includes tests which exercise various semantics such as multiple votes for a single block, retention of recent votes, and heights the height immediately below, exactly at, and immediately above the retention threshold. It also includes a separate test for the boundary cases that does not rely on the full test harness.
davecgh
force-pushed
the
mempool_prune_vote_metadata
branch
from
October 7, 2026 21:25
c9ee0da to
cd33677
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This requires #3804.
The vote metadata that is retained independently of the vote transactions is currently retained indefinitely which means it slowly grows over time without bound as the chain advances.
This remedies that by implementing pruning such that vote metadata is removed once the referenced block is sufficiently far behind the current best height. The pruning threshold is aligned with the existing vote retention policy.
It also includes extensive tests for the vote pruning logic.