Repository navigation
addrmgr: Properly scale up. #1131
Description
Activity
- added a commit that references this issue
on Mar 6, 2018 PR #1132 partially addresses the issue by changing the constants accordingly.
However, the change in isolation is problematic, because after applying it old
peers.json files will still load, but with many empty new tried buckets and
potentially overfull old tried buckets.I'm not sure what the implications are and what would be the best approach to solve it.
Some ideas:- Bump
serialisationVersionand somehow "rebalance" tried buckets after loading old version. - Bump
serialisationVersionand simply invalidate old version. That is, bootstrapping again from seeders.
Any ideas?
- Bump
Commit c80c8e7 was supposed to mimic
Bitcoin Core commit bitcoin/bitcoin@1d21ba2 in order to implement the suggested Countermeasure 6 in
Eclipse Attacks on Bitcoin’s Peer-to-Peer Network, Ethan
Heilman, Alison Kendler, Aviv Zohar, Sharon Goldberg. ePrint Archive
Report 2015/263. March 2015.
However, erroneously the
triedBucketSizewas increased instead of thetriedBucketCount.