Implement cmd+w to close tab instead of window #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| store.dispatch(setConsoleVisibility(!state.ui.consoleVisible)) | ||
| }) | ||
|
|
||
| ipc.on(SHOULD_CLOSE_TAB, () => { |
Contributor
There was a problem hiding this comment.
Everything else looks good. My only request is to move this logic into an action. Now that it's being used in two places... probably should've done this earlier anyway.
I'm thinking you can put it in web/compositeFileActions.js ... the block of logic looks and behaves similarly to the openFile() function in there.
TabbedEditor.jsx and ipcActionEmitter.js can then dispatch the high-level action rather than duplicating functionality.
Contributor
Author
|
Updated in the new commits. The logic can be found as closeTabWindow in web/compositeFileActions.js. |
Contributor
|
|
gdowens
pushed a commit
to gdowens/deco-ide
that referenced
this pull request
Jun 20, 2016
* Implement cmd+w to close tab instead of window * move close tab to compositeFileActions
gdowens
added a commit
that referenced
this pull request
Jun 27, 2016
* Update README Update download link in README * Update json gem dependency version to support newer rubies See: ruby/json#229 * new secrets for travis-org * add correct aws access key * Fixed Link Crash in Help Menu * Add sans-serif fallback to Helvetica styles (#37) * add npm registry setting * Move npmRegistry outside of options * Implement Show in Finder in File Tree Context Menu * Only show custom npm registries in progressbar * Use npm registry setting in install dialog * Create uninstall.sh Uninstaller script * Initial commit Uninstalling script for OSX * if watchman is already in path, do not use our own binary (#64) * Moved uninstaller moved from /desktop/uninstaller/uninstaller.sh to /desktop/deco_unpack_lib/uninstaller/uninstaller.sh * Moved it * Update uninstall.sh * Update "Project" template to RN 0.26.3 * scriptable cli-based system for building and launching in Deco (#71) * File tree matching uses full path instead of name to identify root * Remove debugging console.log * Use Electron remote for path instead of including module, workaround for missing / from paths which needs to be revisited for Windows support * Removed unused lodash imports * Updates "Project" template to RN 0.27.2 * Adds gulp task & instructions for upgrading the temporary project template * Implement cmd+w to close tab instead of window (#83) * Implement cmd+w to close tab instead of window * move close tab to compositeFileActions * copy in postinstall to Scripts path (#96) 👍 * finalize build system v1, include android support, packager switch, some misc fixes (#90) * Add focus/blur/unload events to telemetry (#97) * - [x] [iOS, Android] toggle (#98) - [x] [AVD, Genymotion] toggle - [X] Timeout = 60s, less frequent message - [X] Tweak Android launch wording - [X] Tweak packager toggle button wording - [X] Tweak 'using default config' wording - [X] Increase left sidebar original width * fix and polish error scenarios for android simulator menu (#99) 👍 * bump build number to 0.7.0
gdowens
added a commit
that referenced
this pull request
Jun 27, 2016
* Update README Update download link in README * Update json gem dependency version to support newer rubies See: ruby/json#229 * new secrets for travis-org * add correct aws access key * Fixed Link Crash in Help Menu * Add sans-serif fallback to Helvetica styles (#37) * add npm registry setting * Move npmRegistry outside of options * Implement Show in Finder in File Tree Context Menu * Only show custom npm registries in progressbar * Use npm registry setting in install dialog * Create uninstall.sh Uninstaller script * Initial commit Uninstalling script for OSX * if watchman is already in path, do not use our own binary (#64) * Moved uninstaller moved from /desktop/uninstaller/uninstaller.sh to /desktop/deco_unpack_lib/uninstaller/uninstaller.sh * Moved it * Update uninstall.sh * Update "Project" template to RN 0.26.3 * scriptable cli-based system for building and launching in Deco (#71) * File tree matching uses full path instead of name to identify root * Remove debugging console.log * Use Electron remote for path instead of including module, workaround for missing / from paths which needs to be revisited for Windows support * Removed unused lodash imports * Updates "Project" template to RN 0.27.2 * Adds gulp task & instructions for upgrading the temporary project template * Implement cmd+w to close tab instead of window (#83) * Implement cmd+w to close tab instead of window * move close tab to compositeFileActions * copy in postinstall to Scripts path (#96) 👍 * finalize build system v1, include android support, packager switch, some misc fixes (#90) * Add focus/blur/unload events to telemetry (#97) * - [x] [iOS, Android] toggle (#98) - [x] [AVD, Genymotion] toggle - [X] Timeout = 60s, less frequent message - [X] Tweak Android launch wording - [X] Tweak packager toggle button wording - [X] Tweak 'using default config' wording - [X] Increase left sidebar original width * fix and polish error scenarios for android simulator menu (#99) 👍 * bump build number to 0.7.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #78. I didn't rebind the close window to a new command, which I wasn't sure would be something that was needed.