File tree matching uses full path instead of name to identify root #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for missing / from paths which needs to be revisited for Windows support
|
|
dchen
changed the title
dchen
changed the title
Contributor
|
I know @dabbott has been working on a refactor for file tree logic — wait on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get the "relative root array", it was previously using indexOf to find the position of the directory that matches the project name. The name string isn't unique enough of an identifier, so if the same name was present in any directory above the project, it would unexpectedly match that one.
This modifies the behavior to check against the full root path instead. I also renamed the variable "path" to "workingPath" in a few places to avoid confusion with the path module.
Needs more testing. Fixes #66.