Bug: Analytics scripts are executed on deploy previews and send unwanted data

[yuriassuncx]

Problem

The Analytics component in website/components/Analytics.tsx is currently loading Google Analytics and Google Tag Manager scripts even in deploy preview environments (e.g., *.deno.dev or deco-sites-*.deno.dev).

This happens because of the following check:

const isDeploy = !!context.isDeploy;

On Deno, this value is true not only for production, but also for deploy previews. As a result, analytics scripts are executed in previews, sending data to GA/GTM from non-production domains. These preview domains get marked as monitored domains in Google Tag diagnostics, which triggers errors and pollutes production analytics.

Impact

• Unwanted data: Preview/staging events are mixed with production analytics.
• Errors/warnings: Google Tag Manager flags preview domains as unauthorized/monitored, leading to console errors.
• Harder QA: Makes testing/debugging more difficult, since preview data pollutes real reports.

Suggested Solution

Improve the environment detection so analytics only runs in production. Possible approaches:

• Use a stricter environment flag (e.g., context.isProduction or an explicit DECO_ENV === 'production').
• Exclude preview domains explicitly (*.deno.dev, deco-sites-*.deno.dev).
• Introduce a new config/prop (e.g., enableAnalytics) that defaults to false for previews and true only in production.

Example change:

- const isDeploy = !!context.isDeploy;
+ const isProduction = context.env?.DECO_ENV === "production" || context.isProduction;

- {isDeploy && ( ...analytics scripts... )}
+ {isProduction && ( ...analytics scripts... )}

Expected Outcome

Analytics scripts (GTM/GA) should only run in true production environments.
No data should be sent from deploy previews, ensuring:

• Clean analytics data.
• No Google Tag Manager errors from preview domains.
• A more reliable debugging and testing experience.

---

Suggested label: analytics

[decobot]

💡 Solução Detalhada

O problema está na linha 129 de website/components/Analytics.tsx, onde o código usa context.isDeploy para determinar se deve carregar os scripts de analytics:

const isDeploy = !!context.isDeploy;

Este flag é true tanto em produção quanto em deploy previews do Deno Deploy, causando o carregamento indevido dos scripts analytics em ambientes de teste.

📝 Implementação da Correção

Substituir a verificação atual por uma que identifique apenas produção real:

// website/components/Analytics.tsx (linha 129)
- const isDeploy = !!context.isDeploy;
+ const isProduction = (() => {
+   // Check for production environment via explicit flag
+   if (context.deploymentId && !context.site?.includes(".deno.dev") && !context.site?.includes("deco-sites-")) {
+     return true;
+   }
+   // Alternative: use explicit DECO_ENV environment variable
+   return Deno.env.get("DECO_ENV") === "production";
+ })();

E atualizar a condicional na linha 137:

- {isDeploy && (
+ {isProduction && (

🎯 Solução Alternativa (Mais Simples)

Se preferir uma abordagem mais direta, adicione uma prop explícita:

export interface Props {
  trackingIds?: string[];
  googleAnalyticsIds?: string[];
  src?: string;
  disableAutomaticEventPush?: boolean;
+  /**
+   * @description Enable analytics only in production. Defaults to false for safety.
+   * @default false
+   */
+  enableInProduction?: boolean;
}

export default function Analytics(
-  { trackingIds, src, googleAnalyticsIds, disableAutomaticEventPush }: Props,
+  { trackingIds, src, googleAnalyticsIds, disableAutomaticEventPush, enableInProduction }: Props,
) {
-  const isDeploy = !!context.isDeploy;
+  const shouldLoadAnalytics = enableInProduction === true && !!context.isDeploy;

✅ Checklist para Implementação

1. Atualizar website/components/Analytics.tsx com a lógica de detecção de produção
2. Testar em deploy preview (*.deno.dev) - scripts NÃO devem carregar
3. Testar em produção (domínio custom) - scripts DEVEM carregar
4. Verificar console do browser - sem erros do GTM
5. Confirmar no Google Tag Manager que domínios de preview não aparecem como monitorados

🧪 Como Testar

// Adicione um console.log temporário para debug
console.log({
  isDeploy: context.isDeploy,
  site: context.site,
  deploymentId: context.deploymentId,
  shouldLoadAnalytics: isProduction
});

Deploy em preview e verifique que shouldLoadAnalytics é false. Em produção, deve ser true.