Repository navigation
Harden migrations, secret handling, database CI, and releases - #15
Merged
Merged
Conversation
- fail closed with exit 3 when post-apply drift remains - harden PostgreSQL SQL scanning and UTF-8 diagnostics - redact database URL query parameters - reduce shadow database name collisions - add live PostgreSQL and CockroachDB regression coverage - harden and expand the CI database matrix
ORESoftware
marked this pull request as ready for review
August 5, 2026 02:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Migration correctness
dpm applyfail closed with exit code 3 whenever the post-apply catalog still differs from the source, including gated destructive and manual changes.E'...'andU&'...'escape strings, doubled quoted identifiers, valid dollar-quote tags, nested comment-only tails, and UTF-8-safe diagnostics.DISAGREEDcontract when an external checker runs and exits nonzero; only process-launch failures are infrastructure errors.Credential and temporary-file safety
{source}and{target}placeholders and redact their recorded commands and output.0600, shell-quoted paths, and automatic cleanup.0700, and automatic cleanup.CI and repository controls
Release hardening
--locked.cargo publish --dry-run --lockedpreflight.Primary audit finding fixed
Before this change,
dpm applycould detect residual drift after executing a partially gated migration, print a warning, and still exit 0 unless an optional external cross-checker was enabled. Deployment automation could therefore treat a partial migration as successful despite the CLI's documented non-convergence exit code.Validation
cargo clippy --locked --all-targets -- -D warningscargo test --locked --lib— 98 passedcargo test --locked --test fuzz_splitter— 7 passedrustfmt --checkgit diff --checkScoped follow-ups
The GitHub App could not read branch or tag protection settings, so this PR does not claim those repository controls are enabled. This PR deliberately does not merge the larger concurrency, transactional-recovery, or full external-tool supply-chain changes into the convergence fix.