Skip to content

Comments

fix(vm): increase memory limits during migration with hotplugged disks#1947

Merged
diafour merged 1 commit intomainfrom
fix/vm/oomkill-during-migration-with-16-block-devices
Feb 11, 2026
Merged

fix(vm): increase memory limits during migration with hotplugged disks#1947
diafour merged 1 commit intomainfrom
fix/vm/oomkill-during-migration-with-16-block-devices

Conversation

@diafour
Copy link
Member

@diafour diafour commented Feb 3, 2026

Description

Change kubevirt behaviour for target Pod: add 60Mi more memory to the target Pod resource requirements depending on coreFraction value:

  • Increase requests and limits if cpu cores are guaranteed (coreFraction = 100%)
  • Increase limits only if cpu cores are not guaranteed (coreFraction < 100%).

See deckhouse/3p-kubevirt#66

Why do we need it, and what problem does it solve?

This additional memory should prevent OOMKills for the target Pod during VM migration with hotplugged disks.

What is the expected result?

VM with 16 hotplugged disks migrates with no OOMKills.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: vm
type: fix
summary: Prevent OOMKills for the target Pod during VM migration with hotplugged disks.

@diafour diafour added this to the v1.6.0 milestone Feb 3, 2026
@diafour diafour requested review from Isteb4k and fl64 as code owners February 3, 2026 06:26
@diafour diafour requested review from yaroslavborbat and removed request for Isteb4k and fl64 February 3, 2026 06:26
@diafour diafour force-pushed the fix/vm/oomkill-during-migration-with-16-block-devices branch from 9b3f6e0 to 5c34dbc Compare February 5, 2026 16:23
@diafour diafour marked this pull request as draft February 6, 2026 09:41
@diafour diafour force-pushed the fix/vm/oomkill-during-migration-with-16-block-devices branch from 5c34dbc to a12efad Compare February 9, 2026 18:35
Change kubevirt behaviour for target Pod:
add 60Mi more memory to the target Pod resource requirements depending on coreFraction value:
- Increase requests and limits if cpu cores are guaranteed (coreFraction = 100%)
- Increase limits only if cpu cores are not guaranteed (coreFraction < 100%).

Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
@diafour diafour force-pushed the fix/vm/oomkill-during-migration-with-16-block-devices branch from 409f574 to 96bafb5 Compare February 11, 2026 08:24
@diafour diafour marked this pull request as ready for review February 11, 2026 08:25
@diafour diafour merged commit 1e1c306 into main Feb 11, 2026
29 of 30 checks passed
@diafour diafour deleted the fix/vm/oomkill-during-migration-with-16-block-devices branch February 11, 2026 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants