Conversation
loktev-d
changed the title
loktev-d
changed the title
Isteb4k
previously approved these changes
Nov 24, 2025
Contributor
|
Workflow has started. The target step completed with status: failure. |
Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
hardcoretime
requested changes
Dec 4, 2025
| defer func() { conditions.SetCondition(cb, &vdSnapshot.Status.Conditions) }() | ||
|
|
||
| vs, err := h.snapshotter.GetVolumeSnapshot(ctx, vdSnapshot.Name, vdSnapshot.Namespace) | ||
| vs, err := h.snapshotter.GetVolumeSnapshot(ctx, vdSnapshot.Status.VolumeSnapshotName, vdSnapshot.Namespace) |
Contributor
There was a problem hiding this comment.
I think we should generate VolumeSnapshotName beforehand to prevent any panics related to VirtualDiskSnapshot status.
Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
Contributor
|
Workflow has started. The target step completed with status: failure. |
Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
hardcoretime
previously approved these changes
Feb 6, 2026
Contributor
|
Workflow has started. The target step completed with status: success. |
hardcoretime
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements d8v prefixing for
VirtualMachineSnapshotandVirtualDiskSnapshotservice resources according to the ADR for consistent naming across the virtualization module.Key changes:
<name>tod8v-vms-<name>-<uid>format<name>tod8v-vds-<name>-<uid>formatCommonSupplement()method tosupplements.Generator.Status.VirtualMachineSnapshotSecretNameand.Status.VolumeSnapshotName)Why do we need it, and what problem does it solve?
What is the expected result?
Checklist
Changelog entries