feat: add dmt linter #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yalosev
requested changes
Feb 21, 2025
templates/Build.gitlab-ci.yml
Outdated
| - | | ||
| type dmt >/dev/null 2>&1 || | ||
| { | ||
| trdl add dmt https://trrr.flant.dev/trdl-dmt/ 1 b6c51ab3509296ed9e085461ea35a0da70b2ae02ba8d500400670102cb86b100ae56e133c4c5f8dfe843cc995107fdd5f0037043cd6c149a7ae3c03ec9c44d8c && |
There was a problem hiding this comment.
I don't think we need to add it again. We have to install dmt on the setup step.
There was a problem hiding this comment.
Previously, setup dmt was not placed in the general setup. Now moved to this step.
| @@ -5,6 +5,14 @@ | |||
| .build: | |||
| stage: build | |||
| script: | |||
| # Lint | |||
| - | | |||
There was a problem hiding this comment.
I think, we have to separate it for the parallel step Lint on the build stage
Also, make it optional (it can fail)
There was a problem hiding this comment.
Ok, I created a separate step for verification
Example run
yalosev
reviewed
Feb 24, 2025
Co-authored-by: Yuriy Losev <yuriy.losev@flant.com> Signed-off-by: Evsyukov Denis <denis@evsyukov.org>
yalosev
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.