[fix] return exit code 0 when settings check passes #102
Open
[fix] return exit code 0 when settings check passes #102
Conversation
…rnings Signed-off-by: Artem Kuleshov <artem.kuleshov@flant.com>
7d160a4 to
f7a3160
Compare
ipaqsa
reviewed
Apr 14, 2026
ipaqsa
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously CheckSettings always exited with code 1 and wrote JSON to stderr regardless of the validation outcome. Now it exits with 0 when the result is valid with no warnings and no message, and only writes the JSON structure to stderr on exit 1.
Before (always exit 1, always stderr):
replicas: 0 → exit: 1, stderr: {"valid":false,"message":"replicas cannot be 0","warnings":null}
replicas: 1 → exit: 1, stderr: {"valid":true,"message":"","warnings":null}
replicas: 2 → exit: 1, stderr: {"valid":true,"message":"","warnings":["replicas cannot be greater than 3"]}
After (exit 0 when fully valid, stderr only when needed):
replicas: 0 → exit: 1, stderr: {"valid":false,"message":"replicas cannot be 0","warnings":null}
replicas: 1 → exit: 0, stderr: empty
replicas: 2 → exit: 1, stderr: {"valid":true,"message":"","warnings":["replicas cannot be greater than 3"]}