Skip to content

Conversation

@orisano
Copy link
Contributor

@orisano orisano commented Dec 29, 2020

I improved Add performance.

name         old time/op  new time/op  delta
AddSafe-8     155µs ± 1%   137µs ± 1%  -11.73%  (p=0.000 n=9+10)
AddUnsafe-8   145µs ± 3%   125µs ± 1%  -13.87%  (p=0.000 n=10+9)

@deckarep deckarep deleted the branch deckarep:master March 28, 2022 04:40
@deckarep deckarep closed this Mar 28, 2022
@jeffwidman
Copy link
Contributor

This was closed because of the branch change from master to main. If this PR is still relevant, please re-open a PR with this code against main.

@jeffwidman
Copy link
Contributor

@orisano if these benchmarks are indeed still relevant against the new generics-based implementation, then this looks like a useful PR... 11%-13% improvement is nothing to sneeze at!

@orisano orisano deleted the feat-improve-add branch March 28, 2022 08:41
@jeffwidman
Copy link
Contributor

Re-opened / merged as #88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants