[Question] NewSet vs NewSetWith

[ashwek]

How is NewSet different from NewSetWith?

golang-set/set.go

Lines 178 to 180 in 645e1ba

	// NewSet creates and returns a reference to an empty set. Operations
	// on the resulting set are thread-safe.
	func NewSet(s ...interface{}) Set {

golang-set/set.go

Lines 188 to 190 in 645e1ba

	// NewSetWith creates and returns a new set with the given elements.
	// Operations on the resulting set are thread-safe.
	func NewSetWith(elts ...interface{}) Set {

According to NewSet's documentation, it returns reference to an empty set. But that's not true. It returns reference to a set with all the items passed in parameters.

That's exactly what NewSetWith does. So how are they different?

Am i missing something here?

[jeffwidman]

I had the exact same question... @deckarep when you release the generics-compatible version, maybe take that opportunity to also cleanup the API slightly and remove NewSetWith()?

Would it also make sense to remove NewSetFromSlice([]elt) given that someone could write the NewSet([]elt...) and it'd be functionally equivalent and fewer characters... ??

[jeffwidman]

This could easily be fixed by #83 combined with #84.