Skip to content

Fix issue with get_instance_id_info option params #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sabman merged 3 commits into from
Feb 21, 2022
Merged

Fix issue with get_instance_id_info option params #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c7277a
Fix issue with instance_info endpoint params
jsparling Feb 19, 2022
5bbe347
formatting
jsparling Feb 20, 2022
4db5a60
formatting
jsparling Feb 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions lib/fcm.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,9 +188,7 @@ def send_to_topic(topic, options = {})
end

def get_instance_id_info(iid_token, options = {})
params = {
query: options,
}
params = options

for_uri(INSTANCE_ID_API) do |connection|
response = connection.get("/iid/info/" + iid_token, params)
Expand Down
34 changes: 34 additions & 0 deletions spec/fcm_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,6 +499,40 @@
# TODO
end

describe 'getting instance info' do
Copy link
Copy Markdown

@hound hound Bot Feb 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics/BlockLength: Block has too many lines. [27/25]

subject(:get_info) { client.get_instance_id_info(registration_id, options) }

let(:options) { nil }
let(:client) { FCM.new('TEST_SERVER_KEY') }
let(:base_uri) { "#{FCM::INSTANCE_ID_API}/iid/info" }
let(:uri) { "#{base_uri}/#{registration_id}" }
let(:mock_request_attributes) do
{ headers: {
'Authorization' => 'key=TEST_SERVER_KEY',
'Content-Type' => 'application/json'
} }
end

context 'without options' do
it 'calls info endpoint' do
endpoint = stub_request(:get, uri).with(mock_request_attributes)
get_info
expect(endpoint).to have_been_requested
end
end

context 'with detail option' do
let(:uri) { "#{base_uri}/#{registration_id}?details=true" }
let(:options) { { details: true } }

it 'calls info endpoint' do
endpoint = stub_request(:get, uri).with(mock_request_attributes)
get_info
expect(endpoint).to have_been_requested
end
end
end

describe "credentials path" do
it "can be a path to a file" do
fcm = FCM.new("test", "README.md")
Expand Down