Use faraday #55
Merged
Use faraday #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🙏thanks @prcongithub will review ASAP |
|
Any update here? |
|
thanks will push a new version out asap |
jibiel
reviewed
Oct 20, 2019
| @@ -21,5 +21,5 @@ Gem::Specification.new do |s| | |||
| s.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) } | |||
| s.require_paths = ["lib"] | |||
|
|
|||
| s.add_runtime_dependency('httparty', '~> 0.10', '>= 0.10.0') | |||
| s.add_runtime_dependency('faraday','0.15.4') | |||
There was a problem hiding this comment.
The dependency can be too strict for the apps that already using faraday in their Gemfile.
ghiculescu
added a commit
to ghiculescu/fcm
that referenced
this pull request
Dec 23, 2020
Since decision-labs#55 you can't pass client options anymore (well you can but they aren't used for anything). This results in decision-labs#84 which I'm +1 on, but while it's not resolved, better to not imply anything in the docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces httparty with Faraday to support multi threaded systems.
HTTParty uses class variables to define host for connections.
These class variables were modified by fcm to make requests to multiple google api end points.
With Faraday we can use connection instance variables to connect to different api end points and not worry about multiple threads making api calls.