Proposal Wizard creation/update fixes #3744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
agustibr
force-pushed
the
fix/wizard-create-step-cookie_overflow
branch
3 times, most recently
from
0b50fec to
1424173
Compare
agustibr
force-pushed
the
fix/wizard-create-step-cookie_overflow
branch
4 times, most recently
from
d1fedf0 to
383f412
Compare
Contributor
Author
|
@oriolgual thanks 😄 , I'll add some tests and fix the failing test so it can be merged |
agustibr
force-pushed
the
fix/wizard-create-step-cookie_overflow
branch
2 times, most recently
from
98551a8 to
0e57541
Compare
Contributor
|
Yeah, super nice work! Proposals is such a core feature of decidim and it had become quite buggy 💪 |
agustibr
force-pushed
the
fix/wizard-create-step-cookie_overflow
branch
2 times, most recently
from
0853ca1 to
5b73295
Compare
agustibr
force-pushed
the
fix/wizard-create-step-cookie_overflow
branch
from
6fb00ea to
06c3985
Compare
Contributor
Author
|
@decidim/product I hope it's not a problem that I've got to add the create proposal as to the first step of the wizard, as this PR adds validations to this step, such as: body_length, proposal_limit. |
* fix `CookieOverflow` in wizard steps * proposal_length validation on create_step * show has_address checked and address on invalid * ability to update proposal attachment
Contributor
|
@agustibr this needs feedback from @decidim/product, right? |
Contributor
Author
|
@mrcasals or @decidim/lot-core, all checks passed! can you review it |
Contributor
Author
oriolgual
approved these changes
Jul 24, 2018
3 tasks
Contributor
Author
|
Yay! thanks! |
This was referenced Oct 5, 2018
leio10
added a commit
to podemos-info/decidim
that referenced
this pull request
Nov 29, 2018
Similar to what was done in decidim#3744, but with collaborative drafts instead of proposals
leio10
added a commit
to podemos-info/decidim
that referenced
this pull request
Nov 30, 2018
Similar to what was done in decidim#3744, but with collaborative drafts instead of proposals
leio10
added a commit
to podemos-info/decidim
that referenced
this pull request
Dec 4, 2018
Similar to what was done in decidim#3744, but with collaborative drafts instead of proposals
3 tasks
leio10
added a commit
to podemos-info/decidim
that referenced
this pull request
Dec 4, 2018
Similar to what was done in decidim#3744, but with collaborative drafts instead of proposals
leio10
added a commit
to podemos-info/decidim
that referenced
this pull request
Dec 10, 2018
Similar to what was done in decidim#3744, but with collaborative drafts instead of proposals
mrcasals
pushed a commit
that referenced
this pull request
Dec 11, 2018
* Minor improvement, all existing hashtags have its name downcased * Allow to mark hashtags as "extra" hashtags * Improved hashtag renderer performance Before it was doing a query for each tag in the content. With these changes is performing only one query to retrieve all the hashtags. On the other hand, we are losing the GlobalId flexibility, but we were searching specifically for the Decidim::Hashstag GlobalId in the content, so it wasn't so flexible. * Allow HashtagRenderer to ignore extra hashtags and also retrieve them The `render_without_method` was removed to simplify the class interface * Apply hashtag renderer changes to meetings and simplified presenter * Apply hashtag renderer changes to proposals and simplified presenter * Allow to define automatic and suggested hashtags for proposal components * Show users auto hashtags and allow to select suggested hashtags * Missing translations * CodeClimate issues fixed * Meetings test fixed simplifying locales handling in presenter * Test broken by API change fixed * Render hashtags write in collaborative drafts * Improve reusability and mantainability of collaborative drafts Similar to what was done in #3744, but with collaborative drafts instead of proposals * Add extra tags to collaborative drafts * Removed unused i18n keys after refactoring collaborative draft templates Also, I was using proposals translations for collaborative drafts, I've fixed that too * Ignore case of selected suggested hashtags * Commands logic moved from forms * Proposals and collaborative drafts commands hashtags tests * Proposals forms and system tests * Added extra hashtags to admin proposals creation and edition * Hashtag parser and renderer tests for extra hashtags * Tests for collaborative drafts * Fixed geolocalized collaborative drafts * Add changelog entry * Missing params docs added * Very duplicated methods moved to a module and improved naming * hashtags_suggested renamed to suggested_hashtags * Revert changes to non-english locales * hashtags_auto renamed to automatic_hashtags * Cleaner code * Regression test for collaborative drafts with geocoding enabled fixed bug * Update decidim-proposals/app/commands/decidim/proposals/hashtags_methods.rb Co-Authored-By: leio10 <leiodd@gmail.com>
1 task
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Fixes various bugs and improvements on proposal creation and updates.
📌 Related Issues
CookieOverflowin wizard stepsproposal_lengthvalidation on create_stephas_addresschecked andaddresson invalid form📋 Subtasks
CHANGELOGentry📷 Screenshots (optional)
proposal_lengthvalidation:has_addresschecked andaddresson invalid form: