Fix focus trap in modal dialog for sharing #15807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
module: core
module: comments
type: fix
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Ginger-Leo
force-pushed
the
fix/focus-does-not-move-to-sharing-modal
branch
from
36e8188 to
1af0bbd
Compare
alecslupu
requested changes
Dec 17, 2025
Member
alecslupu
left a comment
alecslupu
left a comment
There was a problem hiding this comment.
@Ginger-Leo can you merge with the latest decidim develop branch, I think you have additional work from #15774 that should not be present in this PR.
andreslucena
changed the title
alecslupu
added
release: v0.30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
We were having an issue where when trying to share a something (a meeting for example), if using the keyboard only, user was unable to access the modal.
📌 Related Issues
Link your PR to an issue
Testing
Go to a meeting, click the 'share' button, navigate the modal using only a keyboard.