Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should not treat all situations when anchor file does not point to a map file as invalid #631

Closed
thehenrytsai opened this issue Apr 30, 2020 · 4 comments
Closed

Should not treat all situations when anchor file does not point to a map file as invalid #631

thehenrytsai opened this issue Apr 30, 2020 · 4 comments
Assignees
@csuwildcat
Labels
bug Something isn't working

Comments

@thehenrytsai
Copy link
Collaborator

This is a legitimate case when all operation are deactivates, there would be no map and chunk files. Current code assumes map file must exists, thus invalidates the batch when this occurs.
@thehenrytsai thehenrytsai added the bug Something isn't working label Apr 30, 2020
@csuwildcat
Copy link
Member

Great catch!

@OR13
Copy link
Contributor

OR13 commented May 5, 2020

Can we add a note the spec about this.

@OR13
Copy link
Contributor

OR13 commented May 19, 2020

@csuwildcat spec needs normative language about making this behavior valid.

thehenrytsai added a commit that referenced this issue Nov 25, 2020
@thehenrytsai
fix(ref-imp): #631 - Allowed valid core index file without provisiona…
3c28cf2 
…l index file URI
thehenrytsai added a commit that referenced this issue Nov 25, 2020
@thehenrytsai
fix(ref-imp): #631 - Allowed valid core index file without provisiona…
0c94173 
…l index file URI
@thehenrytsai
Copy link
Collaborator Author

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@csuwildcat csuwildcat

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@csuwildcat @OR13 @thehenrytsai