Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added prune feature #732

Merged
merged 5 commits into from
Apr 26, 2024
Merged

Added prune feature #732

merged 5 commits into from
Apr 26, 2024

Conversation

thehenrytsai
Copy link
Contributor

@thehenrytsai thehenrytsai commented Apr 26, 2024

1st of a few PRs for the prune feature. This one lights up the capability for anyone who is able to perform RecordsDelete, which should be immediately useful to unblock app development.

There will need to be 2 more follow up PRs:

  1. Its own distinct action support in protocol rules.
  2. Ephemeral state keeping to handle unexpected termination and resumption.

@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.52%. Comparing base (a23bbb3) to head (32db04f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #732      +/-   ##
==========================================
- Coverage   98.58%   98.52%   -0.07%     
==========================================
  Files          71       71              
  Lines       10462    10563     +101     
  Branches     1527     1539      +12     
==========================================
+ Hits        10314    10407      +93     
- Misses        142      150       +8     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@LiranCohen LiranCohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great as always! Just a small question.

Copy link
Member

@LiranCohen LiranCohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

@thehenrytsai thehenrytsai merged commit 43fdbc9 into main Apr 26, 2024
4 checks passed
@thehenrytsai thehenrytsai deleted the henrytsai/prune branch April 26, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants