Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#564 - Added delegated grant support for RecordsDelete #609

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

thehenrytsai
Copy link
Contributor

  1. Added delegated grant support for RecordsDelete
  2. Merged mainline positive and negative cases of delegated grants into one test to reduce context switching.

Copy link

codesandbox bot commented Nov 14, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3f8b405) 98.56% compared to head (04c1329) 98.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #609   +/-   ##
=======================================
  Coverage   98.56%   98.56%           
=======================================
  Files          68       68           
  Lines        8359     8373   +14     
  Branches     1218     1218           
=======================================
+ Hits         8239     8253   +14     
  Misses        114      114           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@LiranCohen LiranCohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Having the negative tests right there is really nice.

@thehenrytsai thehenrytsai merged commit 2081a2e into main Nov 16, 2023
@thehenrytsai thehenrytsai deleted the henrytsai/564-delete branch November 16, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants