Added support for unauthenticated queries for published ProtocolsConfigures #446

thehenrytsai · 2023-07-19T18:49:43Z

Added concept of published ProtocolsConfigures
Added support for unauthenticated queries for published ProtocolsConfigures
Retain authorization property when returning results for ProtocolsQuery
Refactored RecordsQuery handler for cleaner auth logic (should be helpful for adding permission auth)

src/handlers/records-query.ts

src/types/message-store.ts

src/interfaces/protocols-query.ts

Dismissing my approval. Realized we need to remove author! from protocols-query.ts

thehenrytsai added 4 commits July 18, 2023 17:59

added support for published protocols

b7cb671

added tests and fixed bugs

88935f8

refactored RecordsQuery handler

84b5a0d

lint and removed commented out code

5a20d77

thehenrytsai requested review from mistermoe, csuwildcat and diehuxx as code owners July 19, 2023 18:49

diehuxx reviewed Jul 19, 2023

View reviewed changes

src/handlers/records-query.ts Show resolved Hide resolved

diehuxx reviewed Jul 19, 2023

View reviewed changes

src/types/message-store.ts Show resolved Hide resolved

diehuxx previously approved these changes Jul 19, 2023

View reviewed changes

diehuxx reviewed Jul 19, 2023

View reviewed changes

src/interfaces/protocols-query.ts Show resolved Hide resolved

addressed review comments

1be5da9

diehuxx approved these changes Jul 19, 2023

View reviewed changes

thehenrytsai merged commit cb6b21f into main Jul 19, 2023

thehenrytsai deleted the henrytsai/published-protocols branch July 19, 2023 20:51

Provide feedback