Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored tests to be independent of store implementation #420

Merged
merged 2 commits into from
Jul 3, 2023
Merged

Refactored tests to be independent of store implementation #420

merged 2 commits into from
Jul 3, 2023

Conversation

thehenrytsai
Copy link
Contributor

  1. Made tests independent of specific store implementations
    Still need more changes to make testing external implementation truly seamless, but at least the story is much better than before.
  2. Moved store implementation specific tests into their own dedicated suites.

@mistermoe
Copy link
Contributor

This is great @thehenrytsai . I wonder what it'd take to export the generalized tests vs. custom store implementers having to fork the repo

@thehenrytsai thehenrytsai merged commit 3e7cd24 into main Jul 3, 2023
@thehenrytsai thehenrytsai deleted the henrytsai/test-store-refactor branch July 3, 2023 21:47
@thehenrytsai
Copy link
Contributor Author

@mistermoe, definitely a much better story to not require forking. This is a baby step towards that ultimate story. Filed #423 to track!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diehuxx diehuxx diehuxx approved these changes

@mistermoe mistermoe Awaiting requested review from mistermoe mistermoe is a code owner

@csuwildcat csuwildcat Awaiting requested review from csuwildcat csuwildcat is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thehenrytsai @mistermoe @diehuxx