Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#306 Validate data format on protocol authd writes #320

Merged
merged 2 commits into from
Apr 25, 2023
Merged

#306 Validate data format on protocol authd writes #320

merged 2 commits into from
Apr 25, 2023

Conversation

diehuxx
Copy link

@diehuxx diehuxx commented Apr 25, 2023

Fully addresses #306

  • Add dataFormats to protocol definition JSON schema
  • Validate that incoming RecordsWrites are within the allowed dataFormats

@csuwildcat
Copy link
Member

Niiice!

thehenrytsai
thehenrytsai approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@thehenrytsai thehenrytsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏
Looks good, just a non-blocking comment.

@diehuxx diehuxx merged commit 5fa931c into main Apr 25, 2023
@csuwildcat
Copy link
Member

Labels could be definitions or constrains, and if so, we'd need to change it right away.

@thehenrytsai thehenrytsai deleted the diehuxx/protocol-data-format branch April 28, 2023 20:14
@thehenrytsai thehenrytsai mentioned this pull request Apr 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thehenrytsai thehenrytsai thehenrytsai approved these changes

@mistermoe mistermoe Awaiting requested review from mistermoe mistermoe is a code owner

@csuwildcat csuwildcat Awaiting requested review from csuwildcat csuwildcat is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@diehuxx @csuwildcat @thehenrytsai