Reject messages with nonnormalize protocol URIs #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diehuxx
requested review from
mistermoe,
csuwildcat and
thehenrytsai
as code owners
diehuxx
force-pushed
the
diehuxx/required-normalized-protocol
branch
from
32b6965 to
3a44c7e
Compare
thehenrytsai
previously approved these changes
Apr 24, 2023
added 2 commits
April 24, 2023 16:25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #265
Revises a previous attempt #314
Changes
To ensure that protocols URIs are bucketed intuitively,
#createmethods auto-normalize protocols for an ergonomic developer experienceTODO
Going to add a little more test coverage in the morning to bring relevant files back up to 100%