#276 - added encryption support to RecordsWrite #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thehenrytsai
requested review from
mistermoe,
csuwildcat and
diehuxx
as code owners
diehuxx
reviewed
Apr 12, 2023
diehuxx
reviewed
Apr 12, 2023
diehuxx
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is A LOT of quality-of-life stuff that can be done to make the SDK much easier to use as follow ups, but this is nevertheless the first complete milestone that lights up the encryption feature.
Some features to be added in follow up PR(s) include:
protocolPathto every protocol-basedRecordsWriteprotocol-contextderivation scheme further