Release: 20240520 #6200
Merged
Release: 20240520 #6200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added VRMDetailItemComponentView and it's prefab to represent an item in the details panel list of VRM export blocking items. * Added VRMItemModel to hold the data needed to show an item's detail in the details panel. * Added method to retrieve a batch of NFT item data from the nft-api server in WearablesFetchingHelper.cs. * Updated WarningBubble.png * Added IVRMDetailsComponentView and a concrete implementation to handle the Details Panel view. Added VRMDetailsController to handle the Details Panel behavior. * Refactored VRMDetailItemComponentView to handle the export feature directly in the Details Panel. Updated VRMItemDetails following FIGMAs. * Updated IBackpackEditorHUDView to add Details Panel close and open event. Updated the concrete implementation to handle the complete UX flows. Updated BackpackEditorHUDController to handle the new Details Panel. Updated BackpackEditorV2Plugin to initialize the VRMDetailsController. Updated WearablesSection.prefab to hold the new Details Panel section. Updated BackpackEditorHUDV2.prefab accordingly. Added VRMExportDetailsPanel.prefab * Fixed compiling error in tests * Fixed prefabs to pass ScrollsIncludesSensibilityMultiplierByPlatform tests * Test for dynamic columns width calculations * Added Amoy network for network checks in WearableItem.cs * Moved DTOs structs to a separated file * Addressed PR comments. * Removed unnessesary preprocessor * Sanitized initial state of the backpack in case the sections were modified in the scene during development. Adjusted prefabs to better align with screen size changes. * Fix wrong network handling for builds outside Unity Editor. * Added CanBeUnequipped extension method for WearableItem in Utils.cs. Added wearableCanBeUnEquipped property to VRMItemModel. Refactored VRMDetailsController and BackpackEditorHUDController to use a data structure that holds wearable urn and whether it can be unequipped. Added active state update for action button in VRMDetailItemComponentvView. Added canBeUnEquipped in NFTDataDTO. Refactored WearableGridController to use the new extension method to check if a wearable can be unequipped. * Added missing wearableCanBeUnEquipped param to instantiation of VRMItemModel * Removed test prefabs. Fixed Details Panel not adjusting properly when resizing the window. * More tweaks for dynamic sizing. * Fixed details panel's titles' small misalignment. * Fixed logic flow for unequipping and closing the details panel and re-opening again. Fixed details panel export button not working. Small code improvements. Added missing unsubscribe calls in several classes. * Minor layout adjustment.
|
After the CI passes: WebThis branch can be previewed at:
Desktop:If you have the launcher installed (download launcher) you can press open on the following link: SDK 7SDK 6More |
* Update protobuf generated classes from protocol. Added new avatar attach points and ids. Updated LoadingAvatar.prefab. * Updated scripts/package.json to point to protocol branch with new avatar attach points * Updated scripts/package.json to protocol@next * Added even more avatar attach points (cherry picked from commit 2a75fac)
anicalbano
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
...
How to test the changes?
Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md
Copilot summary
copilot:summary