-
Notifications
You must be signed in to change notification settings - Fork 96
test: remove offset for character controller #6094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
After the CI passes: WebThis branch can be previewed at:
Desktop:If you have the launcher installed (download launcher) you can press open on the following link: SDK 6/7:More |
❌ The fix fails in areas with automatic triggers, such as in the case of the DCL scene (-107,-94) or True X Energy (100,77) Screen.Recording.2024-02-23.at.11.48.26.mov |
❌ Failed scenes:
🟢 Passed scenes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Verified! No major blockers were found. character movement is working as before
We are going to just go with changing it for SDK7 in that PR #6123 |
What does this PR change?
In the previous version, the character controller's pivot point was located in center, which required us to adjust position synchronization accordingly. This setup led to issues with other clients, especially in scenarios where characters standing on the ground should have a y-coordinate of 0. To address this, we've adjusted the pivot point to sit at the ground level. This eliminates the need to account for an offset and ensuring consistency across different clients decentraland/sdk#903
To implement this adjustment, several changes were necessary:
This modification impacts scenes that rely on distance calculation based on player position, as the pivot point was moved.
Release plan:
This approach will allow us to smoothly introduce this important change, minimizing disruption and ensuring a seamless transition for all users.
How to test the changes?
Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md
Copilot summary
copilot:summary