Skip to content

test: remove offset for character controller #6094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

aixaCode
Copy link
Collaborator

@aixaCode aixaCode commented Feb 20, 2024

What does this PR change?

In the previous version, the character controller's pivot point was located in center, which required us to adjust position synchronization accordingly. This setup led to issues with other clients, especially in scenarios where characters standing on the ground should have a y-coordinate of 0. To address this, we've adjusted the pivot point to sit at the ground level. This eliminates the need to account for an offset and ensuring consistency across different clients decentraland/sdk#903

To implement this adjustment, several changes were necessary:

  • Modified the character controller and realigned all colliders accordingly.
  • An offset was introduced to the camera-following script to maintain its previous behaviour
  • The ground-checking logic was streamlined to remove the offset.
  • Removed offset from kernel when synchronizing the position.

Screenshot 2024-02-22 120547

This modification impacts scenes that rely on distance calculation based on player position, as the pivot point was moved.

Release plan:

  • Conduct thorough initial testing to assess the extent of affected scenes and the severity of any issues.
  • Based on our findings, we will decide on our communication strategy. We plan to share the updated branch with creators, allowing them to evaluate the impact on their scenes. We will provide some time for them to prepare for the change.
  • If all is successful, we will roll out the update on a pre-announced date

This approach will allow us to smoothly introduce this important change, minimizing disruption and ensuring a seamless transition for all users.

How to test the changes?

  1. Launch the explorer
  2. Check the character movement is working as before
  3. Inspect scenes, especially with trigger areas and validate they work properly.

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

Copilot summary

copilot:summary

@aixaCode aixaCode changed the title remove 0.8 offset for position test: remove offset for character controller Feb 20, 2024
@aixaCode aixaCode added the do not merge This PR should not be merged because is experimental or for testing purposes. label Feb 22, 2024
@Ludmilafantaniella
Copy link
Contributor

Ludmilafantaniella commented Feb 23, 2024

❌ The fix fails in areas with automatic triggers, such as in the case of the DCL scene (-107,-94) or True X Energy (100,77)
❌ realm=MVMF21Meta.dcl.eth&position=-63%2C91

Screen.Recording.2024-02-23.at.11.48.26.mov

@aixaCode aixaCode marked this pull request as ready for review February 26, 2024 15:53
@github-actions github-actions bot requested a review from Kinerius February 26, 2024 15:53
@aixaCode
Copy link
Collaborator Author

aixaCode commented Feb 27, 2024

❌ Failed scenes:

  • -107,-95

🟢 Passed scenes:

Copy link
Contributor

@Kinerius Kinerius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@anicalbano anicalbano self-requested a review February 28, 2024 13:45
Copy link
Contributor

@Ludmilafantaniella Ludmilafantaniella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Verified! No major blockers were found. character movement is working as before

@aixaCode
Copy link
Collaborator Author

We are going to just go with changing it for SDK7 in that PR #6123

@aixaCode aixaCode closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge This PR should not be merged because is experimental or for testing purposes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants